fix(model): check attributes specified for included through model#12316
Merged
sushantdhiman merged 1 commit intoMay 26, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12316 +/- ##
==========================================
+ Coverage 93.37% 96.40% +3.02%
==========================================
Files 91 95 +4
Lines 8753 9115 +362
==========================================
+ Hits 8173 8787 +614
+ Misses 580 328 -252
Continue to review full report at Codecov.
|
6 tasks
sushantdhiman
approved these changes
May 26, 2020
Member
|
Thank you very much!! 🚀 |
Contributor
|
Hey @papb, just wondering when you guys are planning the next release to v6? This is something I would like to use. I realise there was a release around a week ago so no pressure 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
This PR is a port of the #12020 to master branch.