Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add Association into OrderItem type #12332

Conversation

swarthy
Copy link
Contributor

@swarthy swarthy commented Jun 2, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Association ordering is preferred in docs, but not allowed from typescript.

@codecov
Copy link

@codecov codecov bot commented Jun 2, 2020

Codecov Report

Merging #12332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12332   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files          95       95           
  Lines        9115     9115           
=======================================
  Hits         8787     8787           
  Misses        328      328           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b86729...35ba3b7. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 65a9e1e into sequelize:master Jun 2, 2020
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants