Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for optional values in "where" clauses #12337

Merged
merged 3 commits into from Jun 5, 2020

Conversation

T0TProduction
Copy link
Contributor

@T0TProduction T0TProduction commented Jun 3, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions? not needed
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? potentially?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

fixes #11564
as discussed in the issue, this might not be the wanted solution. I'm opening a PR though because the issue has been dead for a while and as long as there is no real reason against this change, it will fix the issue.

@codecov
Copy link

@codecov codecov bot commented Jun 3, 2020

Codecov Report

Merging #12337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12337   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files          95       95           
  Lines        9115     9115           
=======================================
  Hits         8787     8787           
  Misses        328      328           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65a9e1e...ad02519. Read the comment docs.

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Jun 4, 2020

@sushantdhiman sushantdhiman added the status: awaiting response label Jun 4, 2020
@T0TProduction
Copy link
Contributor Author

@T0TProduction T0TProduction commented Jun 4, 2020

@sushantdhiman done, I hope I understood how the test is supposed to work 😁

@sushantdhiman sushantdhiman merged commit 2bf7f7b into sequelize:master Jun 5, 2020
4 checks passed
@sushantdhiman sushantdhiman removed the status: awaiting response label Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants