Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate GROUP BY clause if options.group is empty #12343

Merged
merged 1 commit into from Jun 6, 2020

Conversation

theosotr
Copy link
Contributor

@theosotr theosotr commented Jun 5, 2020

Fixes: #12315

@codecov
Copy link

@codecov codecov bot commented Jun 5, 2020

Codecov Report

Merging #12343 into master will increase coverage by 6.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12343      +/-   ##
==========================================
+ Coverage   90.25%   96.40%   +6.14%     
==========================================
  Files          92       95       +3     
  Lines        8973     9116     +143     
==========================================
+ Hits         8099     8788     +689     
+ Misses        874      328     -546     
Impacted Files Coverage Δ
lib/dialects/abstract/query-generator.js 97.39% <100.00%> (+1.26%) ⬆️
lib/dialects/mssql/query-interface.js 100.00% <0.00%> (ø)
lib/dialects/mssql/index.js 100.00% <0.00%> (ø)
lib/dialects/mssql/connection-manager.js 87.17% <0.00%> (ø)
lib/model.js 96.62% <0.00%> (+0.06%) ⬆️
lib/sequelize.js 95.81% <0.00%> (+0.64%) ⬆️
...dialects/abstract/query-generator/helpers/quote.js 100.00% <0.00%> (+6.66%) ⬆️
lib/dialects/mssql/data-types.js 100.00% <0.00%> (+69.87%) ⬆️
lib/dialects/mssql/async-queue.js 100.00% <0.00%> (+76.47%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7afd589...70fb964. Read the comment docs.

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Jun 5, 2020

This needs tests, please add new file group.test.js here, assert that group: [] do not generate any group by statement

@sushantdhiman sushantdhiman added the status: awaiting response label Jun 5, 2020
@theosotr
Copy link
Contributor Author

@theosotr theosotr commented Jun 5, 2020

done

@sushantdhiman sushantdhiman merged commit f367191 into sequelize:master Jun 6, 2020
3 checks passed
@sushantdhiman sushantdhiman removed the status: awaiting response label Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants