Skip to content

Do not generate GROUP BY clause if options.group is empty#12343

Merged
sushantdhiman merged 1 commit intosequelize:masterfrom
theosotr:fix-12315
Jun 6, 2020
Merged

Do not generate GROUP BY clause if options.group is empty#12343
sushantdhiman merged 1 commit intosequelize:masterfrom
theosotr:fix-12315

Conversation

@theosotr
Copy link
Copy Markdown
Contributor

@theosotr theosotr commented Jun 5, 2020

Fixes: #12315

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2020

Codecov Report

Merging #12343 into master will increase coverage by 6.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12343      +/-   ##
==========================================
+ Coverage   90.25%   96.40%   +6.14%     
==========================================
  Files          92       95       +3     
  Lines        8973     9116     +143     
==========================================
+ Hits         8099     8788     +689     
+ Misses        874      328     -546     
Impacted Files Coverage Δ
lib/dialects/abstract/query-generator.js 97.39% <100.00%> (+1.26%) ⬆️
lib/dialects/mssql/query-interface.js 100.00% <0.00%> (ø)
lib/dialects/mssql/index.js 100.00% <0.00%> (ø)
lib/dialects/mssql/connection-manager.js 87.17% <0.00%> (ø)
lib/model.js 96.62% <0.00%> (+0.06%) ⬆️
lib/sequelize.js 95.81% <0.00%> (+0.64%) ⬆️
...dialects/abstract/query-generator/helpers/quote.js 100.00% <0.00%> (+6.66%) ⬆️
lib/dialects/mssql/data-types.js 100.00% <0.00%> (+69.87%) ⬆️
lib/dialects/mssql/async-queue.js 100.00% <0.00%> (+76.47%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7afd589...70fb964. Read the comment docs.

@sushantdhiman
Copy link
Copy Markdown
Contributor

This needs tests, please add new file group.test.js here, assert that group: [] do not generate any group by statement

@sushantdhiman sushantdhiman added the status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action label Jun 5, 2020
@theosotr
Copy link
Copy Markdown
Contributor Author

theosotr commented Jun 5, 2020

done

@sushantdhiman sushantdhiman merged commit f367191 into sequelize:master Jun 6, 2020
@sushantdhiman sushantdhiman removed the status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action label Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sequelize generates a GROUP BY clause even if the 'group' property contains an empty list

2 participants