Do not generate GROUP BY clause if options.group is empty#12343
Merged
sushantdhiman merged 1 commit intosequelize:masterfrom Jun 6, 2020
Merged
Do not generate GROUP BY clause if options.group is empty#12343sushantdhiman merged 1 commit intosequelize:masterfrom
sushantdhiman merged 1 commit intosequelize:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12343 +/- ##
==========================================
+ Coverage 90.25% 96.40% +6.14%
==========================================
Files 92 95 +3
Lines 8973 9116 +143
==========================================
+ Hits 8099 8788 +689
+ Misses 874 328 -546
Continue to review full report at Codecov.
|
Contributor
|
This needs tests, please add new file |
Contributor
Author
|
done |
sushantdhiman
approved these changes
Jun 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #12315