Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add clientMinMessages to Options interface #12375

Merged
merged 1 commit into from Jun 17, 2020
Merged

feat(types): add clientMinMessages to Options interface #12375

merged 1 commit into from Jun 17, 2020

Conversation

josecolella
Copy link
Contributor

@josecolella josecolella commented Jun 16, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • [ X ] Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • [ X ] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • [ X ] Have you added new tests to prevent regressions?
  • [ X ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • [ X ] Did you update the typescript typings accordingly (if applicable)?
  • [ X ] Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

This adds the clientMinMessages to the Options interface for postgres specific configuration

* @param {string|boolean} [options.clientMinMessages='warning'] The PostgreSQL `client_min_messages` session parameter. Set to `false` to not override the database's default.

@codecov
Copy link

@codecov codecov bot commented Jun 16, 2020

Codecov Report

Merging #12375 into master will increase coverage by 0.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12375      +/-   ##
==========================================
+ Coverage   95.92%   96.44%   +0.51%     
==========================================
  Files          92       95       +3     
  Lines        8912     9110     +198     
==========================================
+ Hits         8549     8786     +237     
+ Misses        363      324      -39     
Impacted Files Coverage Δ
lib/dialects/mysql/query.js 98.27% <0.00%> (-0.05%) ⬇️
lib/dialects/mariadb/query.js 87.96% <0.00%> (ø)
lib/dialects/mariadb/connection-manager.js 100.00% <0.00%> (ø)
lib/dialects/mariadb/index.js 100.00% <0.00%> (ø)
lib/sequelize.js 95.81% <0.00%> (+0.64%) ⬆️
lib/dialects/abstract/query-interface.js 93.76% <0.00%> (+1.86%) ⬆️
lib/dialects/mssql/query.js 96.66% <0.00%> (+2.13%) ⬆️
lib/dialects/mariadb/data-types.js 100.00% <0.00%> (+52.63%) ⬆️
lib/dialects/mariadb/query-generator.js 100.00% <0.00%> (+81.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95f7fb5...94a7b97. Read the comment docs.

types/lib/sequelize.d.ts Outdated Show resolved Hide resolved
types/lib/sequelize.d.ts Outdated Show resolved Hide resolved
types/lib/sequelize.d.ts Outdated Show resolved Hide resolved
@sushantdhiman sushantdhiman added the status: awaiting response label Jun 16, 2020
@josecolella
Copy link
Contributor Author

@josecolella josecolella commented Jun 16, 2020

@sushantdhiman Thanks for the PR review, I've made the necessary changes

@sushantdhiman sushantdhiman merged commit 4914367 into sequelize:master Jun 17, 2020
4 checks passed
@josecolella josecolella deleted the feature/add-client-message-to-types branch Jun 17, 2020
@sushantdhiman sushantdhiman removed the status: awaiting response label Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants