New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement .spread in custom event emitter #1277

Merged
merged 2 commits into from Jan 20, 2014

Conversation

3 participants
@janmeier
Member

janmeier commented Jan 20, 2014

Closes #1268

The spread function is almost a direct copy of .then, except that it transforms the arguments into an array.

We could have changed so that then would return an array of values if there are multiple return values, but I don't like that idea. First, it would break BC, for people who rely on and only need the first argument, and secondly, the way i see the promise spec, a promise can only return a single value

Also - back in PR business - woo! Docs comming shortly

@durango

This comment has been minimized.

Member

durango commented Jan 20, 2014

Smart :)

mickhansen added a commit that referenced this pull request Jan 20, 2014

Merge pull request #1277 from janmeier/promiseSpread
Implement .spread in custom event emitter

@mickhansen mickhansen merged commit daf6494 into sequelize:master Jan 20, 2014

1 check passed

default The Travis CI build passed
Details

@janmeier janmeier deleted the janmeier:promiseSpread branch Jan 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment