Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Add documentation for increment method #13254

Merged
merged 3 commits into from Oct 24, 2021
Merged

chore(docs): Add documentation for increment method #13254

merged 3 commits into from Oct 24, 2021

Conversation

drorheller
Copy link
Contributor

@drorheller drorheller commented May 5, 2021 •
edited by papb

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions? -- Irrelevant - docs change
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)? -- Irrelevant - docs change
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #11834

@drorheller drorheller mentioned this pull request May 6, 2021
Closed
7 tasks
@sdepold sdepold self-assigned this Oct 16, 2021
@sdepold
Copy link
Member

sdepold commented Oct 16, 2021

Should we merge this even though we have this? https://sequelize.org/master/manual/model-instances.html#incrementing-and-decrementing-integer-values

@sdepold sdepold added the status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action label Oct 16, 2021
@sdepold sdepold merged commit 4098eb0 into sequelize:main Oct 24, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

aliatsis pushed a commit to creditiq/sequelize that referenced this pull request Jun 2, 2022
@drorheller @drorHellerNielsen
@sdepold @aliatsis
chore(docs): Add documentation for increment method (sequelize#13254)
58bc17d 
* Add documentation for increment utility method

* Edit docs

Co-authored-by: drorh <dror.heller@nielsen.com>
Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talJoffeExelate talJoffeExelate talJoffeExelate approved these changes

Assignees

@sdepold sdepold

Labels
released status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to combine update and increment
4 participants
@drorheller @sdepold @talJoffeExelate @drorHellerNielsen