Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollback PR #13951 in v6 #14004

Merged
merged 1 commit into from Jan 25, 2022
Merged

fix: rollback PR #13951 in v6 #14004

merged 1 commit into from Jan 25, 2022

Conversation

ephys
Copy link
Member

@ephys ephys commented Jan 24, 2022

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Rollbacking changes from #13951 in v6. The change is still present in v7.
I'm opening a follow-up PR to document the breaking change in v7.

Closes #14003

@ephys ephys self-assigned this Jan 24, 2022
@WikiRik
Copy link
Member

@WikiRik WikiRik commented Jan 24, 2022

@ephys I'll let you merge this yourself, but do note that it will trigger an automatic release

@ephys
Copy link
Member Author

@ephys ephys commented Jan 25, 2022

Sounds good
The only failing test is the old flaky mysql one. Let's publish that fix :)

@ephys ephys merged commit 1882f3c into v6 Jan 25, 2022
83 of 84 checks passed
@ephys ephys deleted the ephys/v6-rollback-overload branch Jan 25, 2022
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 25, 2022

🎉 This PR is included in version 6.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

maramizo pushed a commit to maramizo/sequelize that referenced this issue Jun 2, 2022
aliatsis pushed a commit to creditiq/sequelize that referenced this issue Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants