Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for Oracle DB 18c CI #15016

Merged
merged 49 commits into from Sep 22, 2022
Merged

Conversation

nilabja-bhattacharya
Copy link

@nilabja-bhattacharya nilabja-bhattacharya commented Sep 19, 2022

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

PR to support the CI of the minimal supported Oracle DB version

Todos

sudarshan12s and others added 30 commits Jun 14, 2022
* feat(oracle): add oracle dialect support
* fix: addressing review comments
* fix: minor fixes to the review comments
* fix: doc gen is fixed
* fix: autogenerate the primary constraint name
  populateInsertQueryReturnIntoBinds
* fix: incorporated review comments
@nilabja-bhattacharya nilabja-bhattacharya changed the title fix: Support for Oracle DB 18c CI fix: Add support for Oracle DB 18c CI Sep 19, 2022
sdepold
sdepold previously approved these changes Sep 19, 2022
@sdepold sdepold self-requested a review Sep 19, 2022
@sdepold
Copy link
Member

sdepold commented Sep 19, 2022

Hm. Seems the failing tests are consistent across the both oracle versions?

@nilabja-bhattacharya
Copy link
Author

nilabja-bhattacharya commented Sep 19, 2022

The tests that failed in the CI are flaky; they should be fixed with a re-run.

Copy link
Member

@WikiRik WikiRik left a comment

I have a few comments but they are non blocking. Would be nice if you could work on these

dev/oracle/18-slim/privileges.sql Outdated Show resolved Hide resolved
src/dialects/oracle/index.js Show resolved Hide resolved
@nilabja-bhattacharya
Copy link
Author

nilabja-bhattacharya commented Sep 21, 2022

There has been a flaky failure in 2 DBs, it would be good to re-run to failed jobs. Thanks.

Copy link
Member

@WikiRik WikiRik left a comment

One more comment, but I think after that we should be good to merge

package.json Outdated Show resolved Hide resolved
Copy link
Member

@WikiRik WikiRik left a comment

This looks good to me. I do have some points for additional refactor but I'll take those up as part of backporting CI changes that we've done on main to v6.
Thanks for your work on this!

@WikiRik WikiRik merged commit 5f621d7 into sequelize:v6 Sep 22, 2022
49 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2022

🎉 This PR is included in version 6.23.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants