Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update mariadb connector to v3 #16139

Merged
merged 5 commits into from
Jun 18, 2023
Merged

Conversation

ephys
Copy link
Member

@ephys ephys commented Jun 17, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Update the mariadb connector to v3.

This is a breaking change: Our new minimum supported version for the mariadb connector is 3.1.2

As a happy accident, this required fixing #15640 too.

Closes #15640
Closes #14379

@ephys ephys self-assigned this Jun 17, 2023
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to have fix the test for DB2 and then we should be good

…/sequelize into ephys/update-mariadb-connector
@ephys
Copy link
Member Author

ephys commented Jun 18, 2023

I already fixed it but did not notice pushing the code failed 😅

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this together with #16058 so we don't disable and enable the merge queue twice

@ephys ephys merged commit bc26271 into main Jun 18, 2023
49 checks passed
@ephys ephys deleted the ephys/update-mariadb-connector branch June 18, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bulkCreate returns string instead of Date in postgres Upgrade MariaDB connector to v3
2 participants