New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ref #1824] Fix TypeError if got empty rows from findAndCountAll() with group #1849

Merged
merged 1 commit into from Jun 3, 2014

Conversation

3 participants
@OscarHYCheung

OscarHYCheung commented Jun 3, 2014

This error does not exist in version 2.0.0-dev11, so that I have not find out the origin of the bug, and make this fix for version 1.7.x.

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Jun 3, 2014

Looks good.

mickhansen added a commit that referenced this pull request Jun 3, 2014

Merge pull request #1849 from hycheung0509/1.7.0
[Ref #1824] Fix TypeError if got empty rows from findAndCountAll() with group

@mickhansen mickhansen merged commit d2c62f2 into sequelize:1.7.0 Jun 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Jun 3, 2014

Released in 1.7.7

@dgmike

This comment has been minimized.

dgmike commented Jun 3, 2014

👍

IrfanBaqui pushed a commit to IrfanBaqui/sequelize that referenced this pull request Jun 24, 2015

Merge pull request sequelize#1849 from hycheung0509/1.7.0
[Ref sequelize#1824] Fix TypeError if got empty rows from findAndCountAll() with group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment