New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag dottie raw query #2064

Merged
merged 3 commits into from Jul 18, 2014

Conversation

2 participants
@jValdron
Contributor

jValdron commented Jul 18, 2014

Fixes issue #2061 and also #1837. Also contains pull request #2062 as I'm not sure how to separate the two.

@jValdron

This comment has been minimized.

Contributor

jValdron commented Jul 18, 2014

So obviously tests are failing. Will need to adjust them. Gimme a bit to setup my machine for testing and I'll update the tests and duplicate them to have one with the flag and one without.

@janmeier

This comment has been minimized.

Member

janmeier commented Jul 18, 2014

Sweet!

Perhaps the flag should be turned on by default? @mickhansen

And please remember to add it to the API docs ;) (@param tag above sequelize.query)

@jValdron

This comment has been minimized.

Contributor

jValdron commented Jul 18, 2014

I can do a pull request with anything. By default or not? :)

@jValdron

This comment has been minimized.

Contributor

jValdron commented Jul 18, 2014

Let's see if this build works! Fixed the tests and I've changed the docs. It's turned off by default, as #1837 suggests it.

janmeier added a commit that referenced this pull request Jul 18, 2014

@janmeier janmeier merged commit 9dee280 into sequelize:master Jul 18, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment