New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinct option for count #2079

Merged
merged 2 commits into from Jul 23, 2014

Conversation

3 participants
@TheBenji

TheBenji commented Jul 23, 2014

Hey,

not sure that you want it but atm the count (or findAndCountAll) is not really working if you include something.
Now you can use an distinct parameter which fixes that for most cases.

Might helps with #1953 and #1517 too.

Let me know what you think.

  • Ben
Benjamin August
@janmeier

This comment has been minimized.

Member

janmeier commented Jul 23, 2014

This is already implemented in 2.0 - not sure if it's gonna help with the issues mentioned though ...

Do you mind fixing the indentation?

@TheBenji

This comment has been minimized.

TheBenji commented Jul 23, 2014

Yeah, I know that it's in 2.0 but I still need to use 1.7 here and I thought this might be better than build the queries raw.

Sorry about the indentation.

janmeier added a commit that referenced this pull request Jul 23, 2014

Merge pull request #2079 from TheBenji/1.7.0
distinct option for count

@janmeier janmeier merged commit 0944116 into sequelize:1.7.0 Jul 23, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
@janmeier

This comment has been minimized.

Member

janmeier commented Jul 23, 2014

Merged, thanks :)

Benjamin August
@javiercornejo

This comment has been minimized.

javiercornejo commented Sep 4, 2014

I put comment in issue #1953 but it goes here.

@mickhansen
Hi guys! This works fine for me but why this ins't closed? and where is a doc for 2.x updated?

do you need some help with docs?

Best.

IrfanBaqui pushed a commit to IrfanBaqui/sequelize that referenced this pull request Jun 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment