New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of ON DUPLICATE KEY for 'bulkCreate' method (only supported by mysql & mariadb) #2692

Merged
merged 3 commits into from Dec 9, 2014

Conversation

3 participants
@jcombes
Contributor

jcombes commented Dec 8, 2014

No description provided.

@@ -197,13 +198,21 @@ module.exports = (function() {
')');
}.bind(this));
if (options && options.updateOnDuplicate instanceof Array && options.updateOnDuplicate.length) {

This comment has been minimized.

@janmeier

janmeier Dec 8, 2014

Member

I think this shouldn't update the createdAt timestamp.

I know you copied the code from usert, so the bug exists there as well ;) #2668

This comment has been minimized.

@janmeier

janmeier Dec 8, 2014

Member

Oh the fields are specified by an array. Disregard that comment then, I though you defaulted to all fields :)

This comment has been minimized.

@mickhansen

mickhansen Dec 8, 2014

Contributor

Would probably make sense to support true defaulting to all fields aswell.

This comment has been minimized.

@jcombes

jcombes Dec 8, 2014

Contributor

OK to support all fields by default.

jcombes and others added some commits Dec 8, 2014

Revert "Workaround to deal with an issue in node-webkit where the val…
…idate function fails on object literals"
@jcombes

This comment has been minimized.

Contributor

jcombes commented Dec 8, 2014

Have you other comments?
Do you agree with the modifications?

janmeier added a commit that referenced this pull request Dec 9, 2014

Merge pull request #2692 from jcombes/master
Support of ON DUPLICATE KEY for 'bulkCreate' method (only supported by mysql & mariadb)

@janmeier janmeier merged commit f8cf8dc into sequelize:master Dec 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@janmeier

This comment has been minimized.

Member

janmeier commented Dec 9, 2014

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment