New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't format raw 'update' statement result #3800

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@pkoretic
Contributor

pkoretic commented May 25, 2015

this is proposed change from issue #3795
if anything else is needed (tests) please point me in right direction, thanks

don't format raw 'update' statement result
response to issue 3795
@pkoretic

This comment has been minimized.

Contributor

pkoretic commented May 25, 2015

@janmeier
I guess this is mine https://travis-ci.org/sequelize/sequelize/jobs/64005960

  1) [SQLITE] Model update returns the number of affected rows:
     AssertionError: expected undefined to equal 2
      at self.User.update.spread.then.self.User.update.username (test/integration/model.test.js:1085:35)
  From previous event:
      at Promise.spread (lib/promise.js:21:17)
      at test/integration/model.test.js:1084:83
  From previous event:
      at Promise.then (lib/promise.js:21:17)
      at Context.<anonymous> (test/integration/model.test.js:1083:41)
@janmeier

This comment has been minimized.

Member

janmeier commented May 25, 2015

Hmm yea it seems the query is not being properly interpreted as a bulk update query. At least somehow the number of affected rows is not being passed back properly ..

@janmeier janmeier closed this in d216783 May 26, 2015

@janmeier

This comment has been minimized.

Member

janmeier commented May 26, 2015

@pkoretic The problem was that sqlite actually depended on the old behaviour - fixed now :)

IrfanBaqui pushed a commit to IrfanBaqui/sequelize that referenced this pull request Jun 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment