New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When value is null, don't try to convert to Date, instead just leave it #572

Merged
merged 2 commits into from Apr 29, 2013

Conversation

2 participants
@mweibel
Contributor

mweibel commented Apr 29, 2013

I ran into a problem when I have allowed null on a Date-Field and if I tried to match against
null it didn't work. Instead a Date with "Invalid Date" has been put into this field.

I don't know if there needs to be some additional checks, but I think it should work out.

sdepold added a commit that referenced this pull request Apr 29, 2013

@sdepold

This comment has been minimized.

Member

sdepold commented Apr 29, 2013

merged :)

@sdepold sdepold merged commit 9e82d76 into sequelize:master Apr 29, 2013

1 check passed

default The Travis build passed
Details

@mweibel mweibel deleted the mweibel:patch-1 branch Apr 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment