New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues №5755 for v3 branch #6865

Merged
merged 1 commit into from Nov 16, 2016

Conversation

6 participants
@witem
Contributor

witem commented Nov 16, 2016

Backport for: #5931
Closes #5755

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does your issue contain a link to existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Have you added an entry under Future in the changelog?

Description of change

Port changes from #5755 to v3 branch.

@mention-bot

This comment has been minimized.

mention-bot commented Nov 16, 2016

@witem, thanks for your PR! By analyzing the history of the files in this pull request, we identified @janmeier, @BridgeAR and @User4martin to be potential reviewers.

@felixfbecker

This comment has been minimized.

Contributor

felixfbecker commented Nov 16, 2016

Please link the original PR this is a backport for

@witem

This comment has been minimized.

Contributor

witem commented Nov 16, 2016

done

@codecov-io

This comment has been minimized.

codecov-io commented Nov 16, 2016

Current coverage is 93.85% (diff: 100%)

Merging #6865 into v3 will not change coverage

Powered by Codecov. Last update af3d9c1...6217eab

@sushantdhiman sushantdhiman merged commit 229976c into sequelize:v3 Nov 16, 2016

4 checks passed

codecov/patch Coverage not affected when comparing af3d9c1...6217eab
Details
codecov/project 93.85% (+0.00%) compared to af3d9c1
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman

This comment has been minimized.

Member

sushantdhiman commented Nov 16, 2016

@janmeier or @mickhansen will release new patch version soon @witem

@janmeier

This comment has been minimized.

Member

janmeier commented Nov 16, 2016

+ sequelize@3.25.1

@witem witem deleted the witem:v3 branch Nov 16, 2016

@witem witem restored the witem:v3 branch Nov 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment