New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generateThroughJoin Fix - V3 port #6878

Merged
merged 1 commit into from Nov 18, 2016

Conversation

5 participants
@harshithkashyap
Member

harshithkashyap commented Nov 17, 2016

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does your issue contain a link to existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Have you added an entry under Future in the changelog?

Description of change

V3 Port of #6053

@mention-bot

This comment has been minimized.

mention-bot commented Nov 17, 2016

@harshithkashyap, thanks for your PR! By analyzing the history of the files in this pull request, we identified @eseliger, @mickhansen and @BridgeAR to be potential reviewers.

@codecov-io

This comment has been minimized.

codecov-io commented Nov 17, 2016

Current coverage is 93.88% (diff: 100%)

Merging #6878 into v3 will not change coverage

Powered by Codecov. Last update 2090758...af7dbfe

@janmeier janmeier merged commit 65efbd3 into sequelize:v3 Nov 18, 2016

4 checks passed

codecov/patch Coverage not affected when comparing 2090758...af7dbfe
Details
codecov/project 93.88% (+0.00%) compared to 2090758
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@janmeier

This comment has been minimized.

Member

janmeier commented Nov 18, 2016

👍

@harshithkashyap harshithkashyap deleted the harshithkashyap:generate-through-join-v3 branch Nov 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment