New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes creation of polymorphic belongToMany associations in one step #7159 #7181

Merged
merged 2 commits into from Feb 1, 2017

Conversation

4 participants
@elasticsearcher
Contributor

elasticsearcher commented Feb 1, 2017

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does your issue contain a link to existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Have you added an entry under Future in the changelog?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fixes the issue I described in the comments of #7159, which is exactly the same issue except it's located in a different code path.

The following example from the documentation mentions the creation of associations with belongsToMany relations in one step, but it didn't actually work. This PR makes it work.
http://docs.sequelizejs.com/en/latest/docs/associations/#creating-elements-of-a-hasmany-or-belongstomany-association

@mention-bot

This comment has been minimized.

mention-bot commented Feb 1, 2017

@elasticsearcher, thanks for your PR! By analyzing the history of the files in this pull request, we identified @BridgeAR, @mickhansen and @janmeier to be potential reviewers.

@codecov-io

This comment has been minimized.

codecov-io commented Feb 1, 2017

Codecov Report

Merging #7181 into v3 will increase coverage by <.01%.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98abec3...c841585. Read the comment docs.

@janmeier janmeier merged commit 7fa00e0 into sequelize:v3 Feb 1, 2017

4 checks passed

codecov/patch 100% of diff hit (target 94%)
Details
codecov/project 94% (+<.01%) compared to 98abec3
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment