New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unique to a column for Postgres in the migrator should be fixed. Closes #623 #795

Merged
merged 1 commit into from Aug 1, 2013

Conversation

2 participants
@durango
Member

durango commented Jul 31, 2013

No description provided.

if (dialect === "postgres" || dialect === "postgres-native" || dialect === "sqlite") {
expect(isAdmin.defaultValue).to.be.false
} else {
expect(isAdmin.defaultValue).to.equal("0")

This comment has been minimized.

@sdepold

sdepold Aug 1, 2013

Member

we need to fix that :D

@@ -186,6 +185,31 @@ describe(Support.getTestDialectTeaser("Migrator"), function() {
})
describe('addColumn', function() {
it('adds a unique column to the user table', function(done) {

This comment has been minimized.

@sdepold

sdepold Aug 1, 2013

Member

i wonder if this test should actually check for the uniqueness of uniqueName column :)

sdepold added a commit that referenced this pull request Aug 1, 2013

Merge pull request #795 from durango/postgres-migrate-unique
Adding unique to a column for Postgres in the migrator should be fixed. Closes #623

@sdepold sdepold merged commit 3c3bfea into sequelize:master Aug 1, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment