New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres requires empty array to be explicitly cast on update #890

Merged
merged 2 commits into from Sep 6, 2013

Conversation

2 participants
@robraux

robraux commented Sep 5, 2013

This pull request should be considered the sister of #714. It mirrors the same functionality that was added for "inserts" needing to cast explicitly to add empty arrays. If you wish to blank an array through an update, the array must also be explicitly cast.

@durango

This comment has been minimized.

Member

durango commented Sep 5, 2013

Very cool, you mind adding a test to the spec? :) Just a simple on('sql') would suffice :D thanks for the contribution!

@robraux

This comment has been minimized.

robraux commented Sep 5, 2013

New test added as requested, I should have done that originally sorry. I also clarified what the other test was testing. All pass.

durango added a commit that referenced this pull request Sep 6, 2013

Merge pull request #890 from robraux/update-empty-postgres-array
postgres requires empty array to be explicitly cast on update

@durango durango merged commit 8f68c3b into sequelize:master Sep 6, 2013

1 check passed

default The Travis CI build passed
Details
@durango

This comment has been minimized.

Member

durango commented Sep 6, 2013

No problem man, and thanks for the hard work! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment