fix(model): don't add LIMIT in findOne() queries on unique key #9248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharting
force-pushed
the
find-one-unique-column
branch
from
6951dce to
b6d212b
Compare
janmeier
approved these changes
Apr 6, 2018
lib/model.js
Outdated
|
|
||
| if (options.limit === undefined) { | ||
| const pkVal = options.where && options.where[this.primaryKeyAttribute]; | ||
| const uniqueSingleColumns = _(this.uniqueKeys).values().filter(c => c.fields.length === 1).map('column').value(); |
Member
There was a problem hiding this comment.
use .chain here to make it explicit what's happening
jharting
force-pushed
the
find-one-unique-column
branch
from
b6d212b to
819dfa2
Compare
5 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
npm run testornpm run test-DIALECTpass with this change (including linting)?Context
When querying with
findOne()Sequelize addsLIMIT 1to the query to limit the result size. In combination with duplicating joins this may result in a complicated query (subqueryFilter). An optimization exists in Sequelize where if the query's where clause contains the primary key thenLIMIT 1is skipped.Description of change
This change extends the optimization to also cover unique columns.