Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql): duplicate order generated with limit offset #9307

Merged
merged 1 commit into from Apr 15, 2018
Merged

Conversation

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Apr 15, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #9173
Fixes #9008
Fixes #8804

@codecov
Copy link

@codecov codecov bot commented Apr 15, 2018

Codecov Report

Merging #9307 into master will increase coverage by <.01%.
The diff coverage is 100%.

@sushantdhiman sushantdhiman merged commit 0cbb7b9 into master Apr 15, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 95.93%)
Details
codecov/project 95.93% (+<.01%) compared to 40f9c98
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman sushantdhiman deleted the continue-pr branch Apr 15, 2018
@tylerjgarland
Copy link

@tylerjgarland tylerjgarland commented Apr 18, 2018

Is this fix targeted to a specific release?

@tylerjgarland
Copy link

@tylerjgarland tylerjgarland commented Jun 6, 2018

@sushantdhiman , do you know if this patch was released yet?

@dsbert
Copy link

@dsbert dsbert commented Feb 8, 2019

@sushantdhiman Is there any plan to pull this patch into v4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants