Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inject foreignKey when using separate:true #9396

Merged
merged 2 commits into from May 5, 2018
Merged

fix: inject foreignKey when using separate:true #9396

merged 2 commits into from May 5, 2018

Conversation

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented May 5, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #7514 and clean up association codebase

@codecov
Copy link

@codecov codecov bot commented May 5, 2018

Codecov Report

Merging #9396 into master will decrease coverage by <.01%.
The diff coverage is 97.67%.

@sushantdhiman sushantdhiman merged commit a71a019 into master May 5, 2018
4 checks passed
4 checks passed
codecov/patch 97.67% of diff hit (target 95.93%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +1.73% compared to d6cd753
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman sushantdhiman deleted the fix-7514 branch May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant