Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connection-manager): mssql datatype parsing #9470

Merged
merged 3 commits into from May 23, 2018
Merged

Conversation

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented May 23, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #9468

Not sure now tests did not caught this, will check CI with this PR

@codecov
Copy link

@codecov codecov bot commented May 23, 2018

Codecov Report

Merging #9470 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@sushantdhiman sushantdhiman requested a review from sequelize/orm May 23, 2018
Copy link
Member

@eseliger eseliger left a comment

Other than that, looks good :)

@@ -30,6 +27,7 @@ before_test:
- ps: . .\appveyor-setup.ps1

test_script:
- npm ls tedious

This comment has been minimized.

@eseliger

eseliger May 23, 2018
Member

is this related?

This comment has been minimized.

@sushantdhiman

sushantdhiman May 23, 2018
Author Contributor

Debugging, will remove

@@ -8,12 +8,9 @@ services:

shallow_clone: true

cache:

This comment has been minimized.

@eseliger

eseliger May 23, 2018
Member

this was causing the problem? 🤔

This comment has been minimized.

@sushantdhiman

sushantdhiman May 23, 2018
Author Contributor

Appveyor was loading tedious@2.3.1 for which I think everything was working properly as same tests will fail locally with 2.6.1.

So I have removed caching entirely, as this is single test suite it should easily finish before its travis counterpart.

@sushantdhiman sushantdhiman merged commit f290fb5 into master May 23, 2018
4 checks passed
4 checks passed
@codecov
codecov/patch 100% of diff hit (target 95.97%)
Details
@codecov
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +4.02% compared to 47c4d24
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman sushantdhiman deleted the fix-mssql-parsing branch May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants