Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connection-manager): mssql datatype parsing #9470

Merged
merged 3 commits into from
May 23, 2018

Conversation

sushantdhiman
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #9468

Not sure now tests did not caught this, will check CI with this PR

@codecov
Copy link

codecov bot commented May 23, 2018

Codecov Report

Merging #9470 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@sushantdhiman sushantdhiman requested a review from a team May 23, 2018 04:03
Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good :)

appveyor.yml Outdated
@@ -30,6 +27,7 @@ before_test:
- ps: . .\appveyor-setup.ps1

test_script:
- npm ls tedious
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this related?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugging, will remove

@@ -8,12 +8,9 @@ services:

shallow_clone: true

cache:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was causing the problem? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appveyor was loading tedious@2.3.1 for which I think everything was working properly as same tests will fail locally with 2.6.1.

So I have removed caching entirely, as this is single test suite it should easily finish before its travis counterpart.

@sushantdhiman sushantdhiman merged commit f290fb5 into master May 23, 2018
@sushantdhiman sushantdhiman deleted the fix-mssql-parsing branch May 23, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants