fix(connection-manager): mssql datatype parsing#9470
Merged
sushantdhiman merged 3 commits intomasterfrom May 23, 2018
Merged
Conversation
eseliger
reviewed
May 23, 2018
Member
eseliger
left a comment
eseliger
left a comment
There was a problem hiding this comment.
Other than that, looks good :)
appveyor.yml
Outdated
Contributor
Author
There was a problem hiding this comment.
Debugging, will remove
|
|
||
| shallow_clone: true | ||
|
|
||
| cache: |
Member
There was a problem hiding this comment.
this was causing the problem? 🤔
Contributor
Author
There was a problem hiding this comment.
Appveyor was loading tedious@2.3.1 for which I think everything was working properly as same tests will fail locally with 2.6.1.
So I have removed caching entirely, as this is single test suite it should easily finish before its travis counterpart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Fixes #9468
Not sure now tests did not caught this, will check CI with this PR