Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 9515: sync() with "alter:true" doesn't use field name in model definition #9529

Merged
merged 6 commits into from Jun 16, 2018

Conversation

mjcmatrix
Copy link
Contributor

Closes #9515

…mn name, enhance the existing integration tests for add/remove column to verify that the custom column name is used
…vironment"

This reverts commit 3782763.

Remove unrelated documentation commit from current PR branch
@mjcmatrix mjcmatrix changed the title Fix 9515 Fix 9515: sync() with "alter:true" doesn't use field name in model definition Jun 12, 2018
@codecov
Copy link

codecov bot commented Jun 12, 2018

Codecov Report

Merging #9529 into master will increase coverage by <.01%.
The diff coverage is 100%.

lib/model.js Outdated
}
});
_.each(columns, (columnDesc, columnName) => {
const currentAttributes = attributes[columnName];
const currentAttributes = rawAttributes[columnName];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename currentAttributes to currentAttribute

Copy link
Contributor

@sushantdhiman sushantdhiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor change

@sushantdhiman sushantdhiman merged commit d46e207 into sequelize:master Jun 16, 2018
@mjcmatrix mjcmatrix deleted the fix-9515 branch June 20, 2018 18:55
@lyh2668
Copy link

lyh2668 commented Nov 16, 2018

Why is this problem not fixed in version 4.41.2?

@lyh2668
Copy link

lyh2668 commented Nov 16, 2018

@sushantdhiman I upgraded the version to the version 5.0.0-beta.14 and still have this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants