Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 9515: sync() with "alter:true" doesn't use field name in model definition #9529

merged 6 commits into from Jun 16, 2018


Copy link

@mjcmatrix mjcmatrix commented Jun 12, 2018

Closes #9515

mjcmatrix added 4 commits Jun 12, 2018
…enhance the existing integration tests for add/remove column to verify that the custom column name is used

This reverts commit 3782763.

Remove unrelated documentation commit from current PR branch
@mjcmatrix mjcmatrix changed the title Fix 9515 Fix 9515: sync() with "alter:true" doesn't use field name in model definition Jun 12, 2018
Copy link

@codecov codecov bot commented Jun 12, 2018

Codecov Report

Merging #9529 into master will increase coverage by <.01%.
The diff coverage is 100%.

_.each(columns, (columnDesc, columnName) => {
const currentAttributes = attributes[columnName];
const currentAttributes = rawAttributes[columnName];

This comment has been minimized.


sushantdhiman Jun 13, 2018

rename currentAttributes to currentAttribute

Copy link

@sushantdhiman sushantdhiman left a comment

LGTM, one minor change

@sushantdhiman sushantdhiman merged commit d46e207 into sequelize:master Jun 16, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 95.95%)
codecov/project 95.95% (+<.01%) compared to 4c7b103
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
@mjcmatrix mjcmatrix deleted the mjcmatrix:fix-9515 branch Jun 20, 2018
Copy link

@lyh2668 lyh2668 commented Nov 16, 2018

Why is this problem not fixed in version 4.41.2?

Copy link

@lyh2668 lyh2668 commented Nov 16, 2018

@sushantdhiman I upgraded the version to the version 5.0.0-beta.14 and still have this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants