Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): ignore VIRTUAL/getters with attributes.exclude #9568

Merged
merged 4 commits into from Jun 20, 2018
Merged

Conversation

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Jun 20, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #5566
Fixes #5948

@sushantdhiman sushantdhiman requested a review from sequelize/orm Jun 20, 2018
@codecov
Copy link

@codecov codecov bot commented Jun 20, 2018

Codecov Report

Merging #9568 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

@sushantdhiman sushantdhiman merged commit 2c50b7e into master Jun 20, 2018
4 checks passed
4 checks passed
@codecov
codecov/patch 100% of diff hit (target 96.04%)
Details
@codecov
codecov/project Absolute coverage decreased by -0.08% but relative coverage increased by +3.95% compared to 39fa597
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman sushantdhiman deleted the fix-5566 branch Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants