Mssql add option to set encrypt - #9588
Merged
sushantdhiman merged 6 commits intoJun 24, 2018
Merged
Conversation
Contributor
Author
|
I've been able to verify that a console warning was not appearing but I'm not sure how to go about testing it ( I'll accept any and all direction ). |
| delete connectionConfig.options.port; | ||
| } | ||
|
|
||
| if (config.dialectOptions.encrypt && _.isBoolean(config.dialectOptions.encrypt)) { |
Contributor
There was a problem hiding this comment.
connectionConfig.options.encrypt can be overriden by dialectOptions, no need to specially handle them
| } | ||
| } | ||
|
|
||
| //console.log('connectionConfig: ', connectionConfig) |
davidjb
added a commit
to davidjb/sequelize
that referenced
this pull request
Nov 5, 2019
Having `encrypt: false` means that Sequelize is overriding the now-default behaviour of Tedious to use encrypted connections (tediousjs/tedious@70ffe4a). This change allows Tedious to use its own defaults for its connections, which makes configuration more obvious whilst improving the security of the Sequelize users since encryption is used by default. For note, recent versions of Tedious no longer output the `options.encrypt` warning, which means the solution to sequelize#9574 in PR sequelize#9588 is no longer required. This is a breaking change and not backwards compatible; users who want keep using unencrypted connections will need to set `dialectOptions: { options: { encrypt: false } }` in their config.
5 of 6 tasks
davidjb
added a commit
to davidjb/sequelize
that referenced
this pull request
Nov 26, 2019
Having `encrypt: false` means that Sequelize is overriding the now-default behaviour of Tedious to use encrypted connections (tediousjs/tedious@70ffe4a). This change allows Tedious to use its own defaults for its connections, which makes configuration more obvious whilst improving the security of the Sequelize users since encryption is used by default. For note, recent versions of Tedious no longer output the `options.encrypt` warning, which means the solution to sequelize#9574 in PR sequelize#9588 is no longer required. This is a breaking change and not backwards compatible; users who want keep using unencrypted connections will need to set `dialectOptions: { options: { encrypt: false } }` in their config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
encryptoption wasn't exposed for using MSSQL and a warning was emitted. This should expose said option that users can customize. #9574