Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mssql add option to set encrypt #9588

Merged

Conversation

@mirkojotic
Copy link
Contributor

@mirkojotic mirkojotic commented Jun 24, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

encrypt option wasn't exposed for using MSSQL and a warning was emitted. This should expose said option that users can customize. #9574

@mirkojotic
Copy link
Contributor Author

@mirkojotic mirkojotic commented Jun 24, 2018

I've been able to verify that a console warning was not appearing but I'm not sure how to go about testing it ( I'll accept any and all direction ).
Also not sure which part of the docs to change.

@codecov
Copy link

@codecov codecov bot commented Jun 24, 2018

Codecov Report

Merging #9588 into master will not change coverage.
The diff coverage is n/a.

@@ -57,6 +59,10 @@ class ConnectionManager extends AbstractConnectionManager {
delete connectionConfig.options.port;
}

if (config.dialectOptions.encrypt && _.isBoolean(config.dialectOptions.encrypt)) {

This comment has been minimized.

@sushantdhiman

sushantdhiman Jun 24, 2018
Contributor

connectionConfig.options.encrypt can be overriden by dialectOptions, no need to specially handle them

@@ -66,7 +72,7 @@ class ConnectionManager extends AbstractConnectionManager {
connectionConfig.options[key] = config.dialectOptions[key];
}
}

//console.log('connectionConfig: ', connectionConfig)

This comment has been minimized.

@sushantdhiman

sushantdhiman Jun 24, 2018
Contributor

Remove console log

@sushantdhiman sushantdhiman merged commit bb12f8d into sequelize:master Jun 24, 2018
4 checks passed
4 checks passed
@codecov
codecov/patch Coverage not affected when comparing abf4c73...7ce3845
Details
@codecov
codecov/project 95.96% remains the same compared to abf4c73
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
davidjb added a commit to davidjb/sequelize that referenced this pull request Nov 5, 2019
Having `encrypt: false` means that Sequelize is overriding the
now-default behaviour of Tedious to use encrypted connections
(tediousjs/tedious@70ffe4a).

This change allows Tedious to use its own defaults for its
connections, which makes configuration more obvious whilst improving the
security of the Sequelize users since encryption is used by default.

For note, recent versions of Tedious no longer output the `options.encrypt`
warning, which means the solution to sequelize#9574 in PR
sequelize#9588 is no longer required.

This is a breaking change and not backwards compatible; users who want
keep using unencrypted connections will need to set
`dialectOptions: { options: { encrypt: false } }` in their config.
@davidjb davidjb mentioned this pull request Nov 5, 2019
5 of 6 tasks complete
davidjb added a commit to davidjb/sequelize that referenced this pull request Nov 26, 2019
Having `encrypt: false` means that Sequelize is overriding the
now-default behaviour of Tedious to use encrypted connections
(tediousjs/tedious@70ffe4a).

This change allows Tedious to use its own defaults for its
connections, which makes configuration more obvious whilst improving the
security of the Sequelize users since encryption is used by default.

For note, recent versions of Tedious no longer output the `options.encrypt`
warning, which means the solution to sequelize#9574 in PR
sequelize#9588 is no longer required.

This is a breaking change and not backwards compatible; users who want
keep using unencrypted connections will need to set
`dialectOptions: { options: { encrypt: false } }` in their config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants