Skip to content

feat(enum): Adding in drop enum function.#9641

Merged
sushantdhiman merged 4 commits into
sequelize:masterfrom
paulmowat:dropEnum
Jul 16, 2018
Merged

feat(enum): Adding in drop enum function.#9641
sushantdhiman merged 4 commits into
sequelize:masterfrom
paulmowat:dropEnum

Conversation

@paulmowat

@paulmowat paulmowat commented Jul 9, 2018

Copy link
Copy Markdown
Contributor
  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #2554 by adding in dropEnum function requested.

Copied existing dropEnumAll logic, and removed the list of all enums and now passing in enum that we wish want to drop.

@codecov

codecov Bot commented Jul 9, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9641 into master will decrease coverage by <.01%.
The diff coverage is 75%.

@paulmowat

Copy link
Copy Markdown
Contributor Author

Where should I add test to for this?

@sushantdhiman

Copy link
Copy Markdown
Contributor

@paulmowat you can add test in a new file dropEnum.test.js here

@sushantdhiman sushantdhiman merged commit 11d4a20 into sequelize:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants