Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(enum): Adding in drop enum function. #9641

Merged
merged 4 commits into from Jul 16, 2018

Conversation

@paulmowat
Copy link
Contributor

@paulmowat paulmowat commented Jul 9, 2018

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #2554 by adding in dropEnum function requested.

Copied existing dropEnumAll logic, and removed the list of all enums and now passing in enum that we wish want to drop.

@codecov
Copy link

@codecov codecov bot commented Jul 9, 2018

Codecov Report

Merging #9641 into master will decrease coverage by <.01%.
The diff coverage is 75%.

@paulmowat
Copy link
Contributor Author

@paulmowat paulmowat commented Jul 9, 2018

Where should I add test to for this?

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Jul 14, 2018

@paulmowat you can add test in a new file dropEnum.test.js here

paulmowat added 3 commits Jul 15, 2018
@sushantdhiman sushantdhiman merged commit 11d4a20 into sequelize:master Jul 16, 2018
2 of 4 checks passed
2 of 4 checks passed
codecov/patch 75% of diff hit (target 96.02%)
Details
codecov/project 96.02% (-0.01%) compared to 37145bc
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants