Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error message when a value for array has not been defined #9649

Merged
merged 5 commits into from Jul 14, 2018
Merged

Add an error message when a value for array has not been defined #9649

merged 5 commits into from Jul 14, 2018

Conversation

@u9r52sld
Copy link
Contributor

@u9r52sld u9r52sld commented Jul 12, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Adding an error message when a value for ARRAY have not been defined.

See issue: #7932

@codecov
Copy link

@codecov codecov bot commented Jul 12, 2018

Codecov Report

Merging #9649 into master will increase coverage by <.01%.
The diff coverage is 100%.

type.type = dialectTypes[type.type.key].extend(type.type);
if (type instanceof DataTypes.ARRAY) {
if (!type.type) {
throw new Error('A value for ARRAY have not been defined.');

This comment has been minimized.

@Alexsey

Alexsey Jul 12, 2018
Contributor

Has. "A value for ARRAY has not been defined." :)

This comment has been minimized.

@u9r52sld

u9r52sld Jul 13, 2018
Author Contributor

Thank you for pointing it out.
I modified it.

@u9r52sld u9r52sld changed the title Add an error message when a value for array have not been defined Add an error message when a value for array has not been defined Jul 13, 2018
@sushantdhiman sushantdhiman merged commit c90c8d5 into sequelize:master Jul 14, 2018
4 checks passed
4 checks passed
@codecov
codecov/patch 100% of diff hit (target 95.98%)
Details
@codecov
codecov/project 95.98% (+<.01%) compared to fea6db4
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants