Add an error message when a value for array has not been defined#9649
Merged
sushantdhiman merged 5 commits intosequelize:masterfrom Jul 14, 2018
u9r52sld:handle_error_for_array
Merged
Add an error message when a value for array has not been defined#9649sushantdhiman merged 5 commits intosequelize:masterfrom u9r52sld:handle_error_for_array
sushantdhiman merged 5 commits intosequelize:masterfrom
u9r52sld:handle_error_for_array
Conversation
Alexsey
reviewed
Jul 12, 2018
lib/sequelize.js
Outdated
| type.type = dialectTypes[type.type.key].extend(type.type); | ||
| if (type instanceof DataTypes.ARRAY) { | ||
| if (!type.type) { | ||
| throw new Error('A value for ARRAY have not been defined.'); |
Contributor
There was a problem hiding this comment.
Has. "A value for ARRAY has not been defined." :)
Contributor
Author
There was a problem hiding this comment.
Thank you for pointing it out.
I modified it.
u9r52sld
changed the title
sushantdhiman
approved these changes
Jul 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Adding an error message when a value for ARRAY have not been defined.
See issue: #7932