Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validation): Improve validation #9660

Merged
merged 1 commit into from Jul 14, 2018

Conversation

@pi-kei
Copy link
Contributor

@pi-kei pi-kei commented Jul 14, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #9648
Adds useful info to validation error that comes from type validators when typeValidation option is on. ValidationError will contain one ValidationErrorItem with the following properties:

  • path: name of the field
  • value: value of the field
  • instance: always null
  • validatorKey: string formatted as <TYPE> validator (INTEGER validator)
Add more info to type validation errors
Skip validations for fields with value that is SequelizeMethod

Closes #9648
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Jul 14, 2018

Also fixes #9488

@codecov
Copy link

@codecov codecov bot commented Jul 14, 2018

Codecov Report

Merging #9660 into master will increase coverage by <.01%.
The diff coverage is 100%.

@sushantdhiman sushantdhiman merged commit 735b2a4 into sequelize:master Jul 14, 2018
4 checks passed
4 checks passed
@codecov
codecov/patch 100% of diff hit (target 95.98%)
Details
@codecov
codecov/project 95.99% (+<.01%) compared to 31113ce
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pi-kei pi-kei deleted the pi-kei:improve-validation branch Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants