Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to access json value with nested include #9662

Merged
merged 6 commits into from Jul 23, 2018
Merged

Enable to access json value with nested include #9662

merged 6 commits into from Jul 23, 2018

Conversation

@u9r52sld
Copy link
Contributor

@u9r52sld u9r52sld commented Jul 15, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Enable to access json value with nested include.

See issue: #7956

@@ -48,6 +48,10 @@ function quoteIdentifier(dialect, identifier, options) {
return Utils.addTicks(Utils.removeTicks(identifier, '`'), '`');

case 'postgres':
if (identifier.indexOf('#>>') > 0) {

This comment has been minimized.

@sushantdhiman

sushantdhiman Jul 18, 2018
Contributor

quote helper should not handle this, query generator is more suited for this

This comment has been minimized.

@u9r52sld

u9r52sld Jul 18, 2018
Author Contributor

Thank you for telling me this. I'll git it a try.

@codecov
Copy link

@codecov codecov bot commented Jul 19, 2018

Codecov Report

Merging #9662 into master will increase coverage by <.01%.
The diff coverage is 100%.

@sushantdhiman sushantdhiman merged commit 63d4aaa into sequelize:master Jul 23, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 96.02%)
Details
codecov/project 96.02% (+<.01%) compared to f81e138
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants