Skip to content

belongsToMany.add returns array of intermediate table instance - #9700

Merged
sushantdhiman merged 1 commit into
sequelize:masterfrom
u9r52sld:avoid-array-of-array
Jul 22, 2018
Merged

sushantdhiman merged 1 commit into
sequelize:masterfrom
u9r52sld:avoid-array-of-array

Conversation

@u9r52sld

@u9r52sld u9r52sld commented Jul 22, 2018 •

Copy link
Copy Markdown
Contributor

…es table

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

belongsToMany.add returns array of intermediate table instance, not nested array of array.

See issue: #8377

@u9r52sld u9r52sld changed the title fix(array-of-array): belongs-to-many.add returns array of intermediat… belongsToMany.add returns array of intermediate table instance Jul 22, 2018
@codecov

codecov Bot commented Jul 22, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #9700 into master will increase coverage by <.01%.
The diff coverage is 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants