Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addScope): Only warn no override if defaultScope is defined #9703

Merged

Conversation

@Lawton
Copy link

@Lawton Lawton commented Jul 22, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

if default scope has not be defined ie. Object.keys(this.options.defaultScope).length === 0 then addScope('defaultScope', ...) does not throw an error. (Closes #9407 )

@codecov
Copy link

@codecov codecov bot commented Jul 22, 2018

Codecov Report

Merging #9703 into master will not change coverage.
The diff coverage is 100%.

@sushantdhiman sushantdhiman merged commit be8760d into sequelize:master Jul 22, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 96.02%)
Details
codecov/project 96.02% (+0%) compared to 532286f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants