Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested fix #9787 #9788

Merged
merged 2 commits into from Aug 16, 2018
Merged

Suggested fix #9787 #9788

merged 2 commits into from Aug 16, 2018

Conversation

@dario1985
Copy link
Contributor

@dario1985 dario1985 commented Aug 10, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Copy link
Contributor

@sushantdhiman sushantdhiman left a comment

Fix looks good but this will need a test before merge

@codecov
Copy link

@codecov codecov bot commented Aug 15, 2018

Codecov Report

Merging #9788 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@dario1985 dario1985 force-pushed the dario1985:master branch from 2f7fbca to fead21a Aug 16, 2018
@dario1985
Copy link
Contributor Author

@dario1985 dario1985 commented Aug 16, 2018

@sushantdhiman added! could this be fixed in the 4.x line too?
It generates count mismatch in find&count queries

@sushantdhiman sushantdhiman merged commit 5d0d6a4 into sequelize:master Aug 16, 2018
3 of 4 checks passed
3 of 4 checks passed
codecov/project 96.02% (-0.01%) compared to 5ddb26f
Details
codecov/patch Coverage not affected when comparing 5ddb26f...fead21a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Aug 16, 2018

@dario1985 After recent npm token revokation, my semantic release token is removed and 4.x branch is not setup for release.

You can send a PR and I will merge it when semantic release setup is fixed

@dario1985
Copy link
Contributor Author

@dario1985 dario1985 commented Aug 20, 2018

@sushantdhiman I just created a separated PR for this #9821 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants