Suggested fix #9787 - #9788
Merged
Merged
Conversation
sushantdhiman
suggested changes
Aug 15, 2018
sushantdhiman
left a comment
Contributor
There was a problem hiding this comment.
Fix looks good but this will need a test before merge
Author
|
@sushantdhiman added! could this be fixed in the 4.x line too? |
sushantdhiman
approved these changes
Aug 16, 2018
Contributor
|
@Dario1985 After recent npm token revokation, my semantic release token is removed and 4.x branch is not setup for release. You can send a PR and I will merge it when semantic release setup is fixed |
Author
|
@sushantdhiman I just created a separated PR for this #9821 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change