Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested fix #9787 #9788

Merged
merged 2 commits into from Aug 16, 2018
Merged

Suggested fix #9787 #9788

merged 2 commits into from Aug 16, 2018

Conversation

dario1985
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

@dario1985 dario1985 mentioned this pull request Aug 10, 2018
Closed
sushantdhiman
sushantdhiman suggested changes Aug 15, 2018
View reviewed changes
Copy link
Contributor

@sushantdhiman sushantdhiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good but this will need a test before merge

@codecov
Copy link

codecov bot commented Aug 15, 2018 •
edited

Codecov Report

Merging #9788 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@dario1985
Copy link
Contributor Author

dario1985 commented Aug 16, 2018 •
edited

@sushantdhiman added! could this be fixed in the 4.x line too?
It generates count mismatch in find&count queries

@sushantdhiman sushantdhiman merged commit 5d0d6a4 into sequelize:master Aug 16, 2018
@sushantdhiman
Copy link
Contributor

@dario1985 After recent npm token revokation, my semantic release token is removed and 4.x branch is not setup for release.

You can send a PR and I will merge it when semantic release setup is fixed

@dario1985
Copy link
Contributor Author

@sushantdhiman I just created a separated PR for this #9821 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushantdhiman sushantdhiman sushantdhiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dario1985 @sushantdhiman