Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): Fix edge case crash in bulkCreate ( #9796) #9797



Copy link

@andrewAtPaymentRails andrewAtPaymentRails commented Aug 13, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)? !! - DIALECT=postgres npm run test-docker --- does not work 100% with a fresh pull request
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • [NA] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in

Description of change

Closes #[9796]

Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #9797 into master will not change coverage.
The diff coverage is 100%.

Copy link

Thanks, this issue has been brought to my attention at-least one time #9274, why set is used is basically unknown :D

As this PR aligns bulkCreate with save, I am accepting this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants