fix(model): Fix edge case crash in bulkCreate ( #9796) - #9797
Merged
sushantdhiman merged 4 commits intoAug 15, 2018
Merged
Conversation
Fix issue where auto increment fields were not working correctly.
Contributor
|
Thanks, this issue has been brought to my attention at-least one time #9274, why As this PR aligns bulkCreate with save, I am accepting this change. |
This was referenced Aug 15, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)? !! - DIALECT=postgres npm run test-docker --- does not work 100% with a fresh pull requestDescription of change
Closes #[9796]