Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ignoreDuplicates in Postgres >= 9.5 #9883

Conversation

jedwards1211
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #9882

@jedwards1211
Copy link
Contributor Author

@sushantdhiman looks like AppVeyor failed for no good reason, I can't see why in the log

@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

Merging #9883 into master will increase coverage by 5.03%.
The diff coverage is 100%.

@sushantdhiman
Copy link
Contributor

Make sure this test is running for postgres https://github.com/sequelize/sequelize/blob/master/test/integration/model/bulk-create.test.js#L425

You will need to include onConflictDoNothing to if condition

@jedwards1211
Copy link
Contributor Author

@sushantdhiman okay it's fixed, the test had a transient failure.

@sushantdhiman sushantdhiman merged commit 3a56cf7 into sequelize:master Sep 9, 2018
@sushantdhiman
Copy link
Contributor

Thanks @jedwards1211

@jedwards1211
Copy link
Contributor Author

Thank you!

@jhiner
Copy link

jhiner commented Sep 24, 2018

Hello, do you have any idea when this will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: support ignoreDuplicates in bulkCreate for Postgres 9.5+ (using ON CONFLICT DO NOTHING)
3 participants