Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres): enum with string COMMENT breaks query #9891

merged 1 commit into from Sep 8, 2018


Copy link

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in

Description of change

Fixes #9149

Added a space in indexOf check, enum with COMMENT is common but COMMENT<space> should be rare or invalid for most use cases, just enough to fix this bug

Copy link

codecov bot commented Sep 8, 2018

Codecov Report

Merging #9891 into master will not change coverage.
The diff coverage is 100%.

@sushantdhiman sushantdhiman merged commit 03155ad into master Sep 8, 2018
@sushantdhiman sushantdhiman deleted the fix-comment-enum-case branch September 8, 2018 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Sequelize.ENUM does not support the substring COMMENT
1 participant