Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section for restore() to tutorial docs #9917

Merged
merged 1 commit into from Sep 13, 2018

Conversation

@jedwards1211
Copy link
Contributor

@jedwards1211 jedwards1211 commented Sep 13, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Also added a note that creating a new instance with the same primary key as a soft-deleted instance will not work.

fix #9885

@jedwards1211 jedwards1211 force-pushed the jedwards1211:document-restore branch 3 times, most recently from 1a64ef0 to 0c96a15 Sep 13, 2018
and add note that creating a new instance with the same primary key as a soft-deleted instance will not work.
@jedwards1211 jedwards1211 force-pushed the jedwards1211:document-restore branch from 0c96a15 to ce0a361 Sep 13, 2018
@sushantdhiman sushantdhiman merged commit f04601f into sequelize:master Sep 13, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Sep 13, 2018

Thanks

@jedwards1211
Copy link
Contributor Author

@jedwards1211 jedwards1211 commented Sep 13, 2018

Thanks for all your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants