Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-table): support for uniqueKeys #9946

Merged
merged 4 commits into from Sep 21, 2018
Merged

Conversation

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Sep 21, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #9041

@sushantdhiman sushantdhiman force-pushed the create-table-unique-keys branch from f86b7b3 to 805f5ae Sep 21, 2018
@codecov
Copy link

@codecov codecov bot commented Sep 21, 2018

Codecov Report

Merging #9946 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9946      +/-   ##
==========================================
+ Coverage   96.09%   96.09%   +<.01%     
==========================================
  Files          63       63              
  Lines        9398     9402       +4     
==========================================
+ Hits         9031     9035       +4     
  Misses        367      367
Impacted Files Coverage Δ
lib/query-interface.js 91.11% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9ec57...ef5cbb6. Read the comment docs.

@sushantdhiman sushantdhiman force-pushed the create-table-unique-keys branch from 805f5ae to ef5cbb6 Sep 21, 2018
@sushantdhiman sushantdhiman merged commit 057e535 into master Sep 21, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 96.09%)
Details
codecov/project 96.09% (+<.01%) compared to ee9ec57
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman sushantdhiman deleted the create-table-unique-keys branch Sep 21, 2018
@SimonSchick
Copy link
Member

@SimonSchick SimonSchick commented Dec 18, 2018

Was this not backported to v4?

@sushantdhiman
Copy link
Contributor Author

@sushantdhiman sushantdhiman commented Dec 19, 2018

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants