fix(query): check valid warn message (#9919)#9948
Merged
sushantdhiman merged 1 commit intosequelize:masterfrom Sep 29, 2018
Merged
fix(query): check valid warn message (#9919)#9948sushantdhiman merged 1 commit intosequelize:masterfrom
sushantdhiman merged 1 commit intosequelize:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9948 +/- ##
=========================================
- Coverage 96.14% 91.3% -4.84%
=========================================
Files 63 63
Lines 9407 9408 +1
=========================================
- Hits 9044 8590 -454
- Misses 363 818 +455
Continue to review full report at Codecov.
|
Contributor
|
Test case is included in that issue, please use that or create a new one |
tsasaki609
force-pushed
the
iterate-warning-row
branch
from
2bfed34 to
a1f2599
Compare
Contributor
Author
|
Oops I forgot. I made a simple unit test. |
lib/dialects/mysql/query.js
Outdated
| const warningMessage = 'MySQL Warnings (' + (this.connection.uuid||'default') + '): '; | ||
| const messages = []; | ||
| for (const _warningRow of warningResults) { | ||
| if (typeof _warningRow[Symbol.iterator] !== 'function') break; |
Contributor
There was a problem hiding this comment.
continue instead of break
tsasaki609
force-pushed
the
iterate-warning-row
branch
4 times, most recently
from
4e950af to
a564919
Compare
tsasaki609
force-pushed
the
iterate-warning-row
branch
from
a564919 to
668072c
Compare
Contributor
Author
|
I implemented an integration test. |
sushantdhiman
approved these changes
Sep 29, 2018
Contributor
|
Thanks @tsasaki609 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
fix #9919
validate that warning row is iterable