Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sequelize): dialectModule option #9972

Merged
merged 1 commit into from Sep 29, 2018
Merged

Conversation

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Sep 29, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Added support for new configuration option dialectModule. Sequelize instance will use that dialect library instance rather than requiring default dialect module

Fixes #9608
Fixes #7354
Closes #9609

@codecov
Copy link

@codecov codecov bot commented Sep 29, 2018

Codecov Report

Merging #9972 into master will increase coverage by 0.14%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9972      +/-   ##
==========================================
+ Coverage   96.24%   96.39%   +0.14%     
==========================================
  Files          63       63              
  Lines        9408     9395      -13     
==========================================
+ Hits         9055     9056       +1     
+ Misses        353      339      -14
Impacted Files Coverage Δ
lib/sequelize.js 96.58% <ø> (ø) ⬆️
lib/dialects/mssql/connection-manager.js 88.6% <100%> (+3.9%) ⬆️
lib/dialects/postgres/connection-manager.js 93.51% <100%> (+3.08%) ⬆️
lib/dialects/mysql/connection-manager.js 95.23% <100%> (+5.38%) ⬆️
lib/dialects/sqlite/connection-manager.js 97.77% <100%> (+7.77%) ⬆️
lib/dialects/abstract/connection-manager.js 87.6% <81.81%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7091047...a2cbe53. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 6382078 into master Sep 29, 2018
3 of 4 checks passed
3 of 4 checks passed
@codecov
codecov/patch 89.47% of diff hit (target 96.24%)
Details
@codecov
codecov/project 96.39% (+0.14%) compared to 7091047
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman sushantdhiman deleted the dialectModule-option branch Sep 29, 2018
@tlc-sundown tlc-sundown mentioned this pull request Apr 29, 2019
1 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant