Skip to content

feat(sequelize): dialectModule option - #9972

Merged
sushantdhiman merged 1 commit into
masterfrom
dialectModule-option
Sep 29, 2018
Merged

feat(sequelize): dialectModule option#9972
sushantdhiman merged 1 commit into
masterfrom
dialectModule-option

Conversation

@sushantdhiman

Copy link
Copy Markdown
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Added support for new configuration option dialectModule. Sequelize instance will use that dialect library instance rather than requiring default dialect module

Fixes #9608
Fixes #7354
Closes #9609

@codecov

codecov Bot commented Sep 29, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9972 into master will increase coverage by 0.14%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9972      +/-   ##
==========================================
+ Coverage   96.24%   96.39%   +0.14%     
==========================================
  Files          63       63              
  Lines        9408     9395      -13     
==========================================
+ Hits         9055     9056       +1     
+ Misses        353      339      -14
Impacted Files Coverage Δ
lib/sequelize.js 96.58% <ø> (ø) ⬆️
lib/dialects/mssql/connection-manager.js 88.6% <100%> (+3.9%) ⬆️
lib/dialects/postgres/connection-manager.js 93.51% <100%> (+3.08%) ⬆️
lib/dialects/mysql/connection-manager.js 95.23% <100%> (+5.38%) ⬆️
lib/dialects/sqlite/connection-manager.js 97.77% <100%> (+7.77%) ⬆️
lib/dialects/abstract/connection-manager.js 87.6% <81.81%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7091047...a2cbe53. Read the comment docs.

@sushantdhiman
sushantdhiman merged commit 6382078 into master Sep 29, 2018
@sushantdhiman
sushantdhiman deleted the dialectModule-option branch September 29, 2018 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant