Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: fix memory leak due to instance reference in validators #9973

merged 1 commit into from Sep 29, 2018


Copy link

@sushantdhiman sushantdhiman commented Sep 29, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in

Description of change

Fix a memory leak due to uncollected reference to modelInstance in isImmutable validator



Copy link

@codecov codecov bot commented Sep 29, 2018

Codecov Report

Merging #9973 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9973      +/-   ##
- Coverage   96.39%   96.38%   -0.01%     
  Files          63       63              
  Lines        9395     9389       -6     
- Hits         9056     9050       -6     
  Misses        339      339
Impacted Files Coverage Δ
lib/instance-validator.js 97.54% <100%> (-0.04%) ⬇️
lib/utils/validator-extras.js 97.56% <100%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6382078...b8932bb. Read the comment docs.

@sushantdhiman sushantdhiman merged commit f7585ac into master Sep 29, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 96.39%)
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.6% compared to 6382078
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
@sushantdhiman sushantdhiman deleted the fix-memory-leak-1 branch Sep 29, 2018
uneess added a commit to uneess/sequelize that referenced this pull request Oct 15, 2018
sushantdhiman added a commit that referenced this pull request Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant