perf: fix memory leak due to instance reference in validators - #9973
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9973 +/- ##
==========================================
- Coverage 96.39% 96.38% -0.01%
==========================================
Files 63 63
Lines 9395 9389 -6
==========================================
- Hits 9056 9050 -6
Misses 339 339
Continue to review full report at Codecov.
|
uneess
pushed a commit
to uneess/sequelize
that referenced
this pull request
Oct 15, 2018
sushantdhiman
pushed a commit
that referenced
this pull request
Oct 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Fix a memory leak due to uncollected reference to
modelInstanceinisImmutablevalidatorBefore

After
