Skip to content

refactor(Model): remove .all() alias of .findAll() - #9975

Merged
sushantdhiman merged 3 commits into
sequelize:masterfrom
madmoizo:remove-alias-model-all
Oct 2, 2018
Merged

sushantdhiman merged 3 commits into
sequelize:masterfrom
madmoizo:remove-alias-model-all

Conversation

@madmoizo

@madmoizo madmoizo commented Oct 1, 2018

Copy link
Copy Markdown
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Little addition to the previous PR #9933
Remove the .all() alias of .findAll()

@codecov

codecov Bot commented Oct 1, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #9975 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9975      +/-   ##
==========================================
- Coverage   96.38%   96.38%   -0.01%     
==========================================
  Files          63       63              
  Lines        9389     9388       -1     
==========================================
- Hits         9050     9049       -1     
  Misses        339      339
Impacted Files Coverage Δ
lib/model.js 96.66% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7585ac...8b204df. Read the comment docs.

@sushantdhiman
sushantdhiman merged commit 053145c into sequelize:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants