Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Model): remove .all() alias of .findAll() #9975

Merged
merged 3 commits into from Oct 2, 2018
Merged

refactor(Model): remove .all() alias of .findAll() #9975

merged 3 commits into from Oct 2, 2018

Conversation

@frlinw
Copy link
Contributor

@frlinw frlinw commented Oct 1, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Little addition to the previous PR #9933
Remove the .all() alias of .findAll()

@codecov
Copy link

@codecov codecov bot commented Oct 1, 2018

Codecov Report

Merging #9975 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9975      +/-   ##
==========================================
- Coverage   96.38%   96.38%   -0.01%     
==========================================
  Files          63       63              
  Lines        9389     9388       -1     
==========================================
- Hits         9050     9049       -1     
  Misses        339      339
Impacted Files Coverage Δ
lib/model.js 96.66% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7585ac...8b204df. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 053145c into sequelize:master Oct 2, 2018
3 of 4 checks passed
3 of 4 checks passed
codecov/project 96.38% (-0.01%) compared to f7585ac
Details
codecov/patch Coverage not affected when comparing f7585ac...8b204df
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants