New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain joinTableAttributes
versus include: { attributes }
in the manuals
#97
Comments
THANK YOU! I spent hours trying to find how to omit the through table's attributes entirely while using a mixin and this was exactly what I was looking for. Adding to this, using joinTableAttributes is not possible while using TypeScript as the type BelongsToManyGetAssociationsMixin doesn't include it so it might be a good idea to update all the mixin types as well. |
😬
Actually this was already fixed earlier this week at sequelize/sequelize#11818, however there was no release yet. |
This issue has been automatically marked as stale because it has been open for 7 days without activity. It will be closed if no further activity occurs. If this is still an issue, just leave a comment or remove the "stale" label. 🙂 |
This address #11847 partially at least - I'm not sure where else it should be documented.
* Document `joinTableAttributes` in `belongsToMany` mixin This address #11847 partially at least - I'm not sure where else it should be documented. * Tweak wording a bit * Try to make this a little clearer Co-authored-by: fncolon <fncolon@pm.me>
* Document `joinTableAttributes` in `belongsToMany` mixin This address #11847 partially at least - I'm not sure where else it should be documented. * Tweak wording a bit * Try to make this a little clearer Co-authored-by: fncolon <fncolon@pm.me>
Issue Description
Currently the
joinTableAttributes
option is barely mentioned in the manuals (ctrl+f here).What was unclear/insufficient/not covered in the documentation
What does it do and how it relates to the more known
include: { attributes: [ /* ... */ ] }
optionIf possible: Provide some suggestion on how we can enhance the docs
Just briefly mention it in the manuals and explain its difference, no need for complicated things...
Issue Template Checklist
Is this issue dialect-specific?
Would you be willing to resolve this issue by submitting a Pull Request?
The text was updated successfully, but these errors were encountered: