Store last made choice for rule filter visibility across sessions (#3304)

Author: dmoagx

Source/SPConstants.h

@@ -392,6 +392,7 @@ extern NSString *SPResetAutoIncrementAfterDeletionOfAllRows;
 extern NSString *SPFavoriteColorList;
 extern NSString *SPDisplayBinaryDataAsHex;
 extern NSString *SPMonospacedFontSize;
+extern NSString *SPRuleFilterEditorLastVisibilityChoice;
 
 // Hidden Prefs
 extern NSString *SPPrintWarningRowLimit;

Source/SPConstants.m

@@ -177,6 +177,7 @@
 NSString *SPFavoriteColorList                    = @"FavoriteColorList";
 NSString *SPDisplayBinaryDataAsHex               = @"DisplayBinaryDataAsHex";
 NSString *SPMonospacedFontSize                   = @"MonospacedFontSize";
+NSString *SPRuleFilterEditorLastVisibilityChoice = @"RuleFilterEditorLastVisibilityChoice";
 
 // Hidden Prefs
 NSString *SPPrintWarningRowLimit                 = @"PrintWarningRowLimit";

Source/SPTableContent.m

@@ -175,14 +175,14 @@ - (id)init
 		tableRowsSelectable = YES;
 		isFirstChangeInView = YES;
 
-		showFilterRuleEditor = NO;
-
 		isFiltered = NO;
 		isLimited = NO;
 		isInterruptedLoad = NO;
 
 		prefs = [NSUserDefaults standardUserDefaults];
 
+		showFilterRuleEditor = [prefs boolForKey:SPRuleFilterEditorLastVisibilityChoice];
+
 		usedQuery = [[NSString alloc] initWithString:@""];
 
 		tableLoadTimer = nil;
@@ -1350,6 +1350,7 @@ - (void)filterTableTask
 - (IBAction)toggleRuleEditorVisible:(id)sender
 {
 	BOOL shouldShow = !showFilterRuleEditor;
+	[prefs setBool:shouldShow forKey:SPRuleFilterEditorLastVisibilityChoice];
 	[self setRuleEditorVisible:shouldShow animate:YES];
 	// if this was the active filter before, it no longer can be the active filter when it is hidden
 	if(activeFilter == SPTableContentFilterSourceRuleFilter && !shouldShow) {