Add support for CURRENT_TIMESTAMP(n) in default/on update column of DATETIME/TIMESTAMP fields (part of #2315)

dmoagx · dmoagx · commit 3e69d23923c0 · 2015-11-04T02:01:06.000+01:00
diff --git a/Source/SPConstants.h b/Source/SPConstants.h
@@ -620,6 +620,8 @@ extern NSString *SPBundleShellVariableAllFunctions;
 extern NSString *SPBundleShellVariableAllViews;
 extern NSString *SPBundleShellVariableAllTables;
 
+extern NSString *SPCurrentTimestampPattern;
+
 typedef NS_ENUM(NSInteger, SPBundleRedirectAction) {
 	SPBundleRedirectActionNone                 = 200,
 	SPBundleRedirectActionReplaceSection       = 201,
diff --git a/Source/SPConstants.m b/Source/SPConstants.m
@@ -431,6 +431,11 @@
 NSString *SPBundleShellVariableSelectedTextRange            = @"SP_SELECTED_TEXT_RANGE";
 NSString *SPBundleShellVariableUsedQueryForTable            = @"SP_USED_QUERY_FOR_TABLE";
 
+#define OWS @"\\s*" /* optional whitespace */
+//                                                CURRENT_TIMESTAMP    [            (           [n]          )    ]
+NSString *SPCurrentTimestampPattern = (@"^" OWS @"CURRENT_TIMESTAMP" @"(?:" OWS @"\\(" OWS @"(\\d*)" OWS @"\\)" @")?" OWS @"$");
+#undef OWS
+
 // URL scheme
 NSString *SPURLSchemeQueryInputPathHeader          = @"/tmp/SP_QUERY_";
 NSString *SPURLSchemeQueryResultPathHeader         = @"/tmp/SP_QUERY_RESULT_";
diff --git a/Source/SPCustomQuery.m b/Source/SPCustomQuery.m
@@ -1996,22 +1996,23 @@ - (void)saveCellValue:(id)anObject forTableColumn:(NSTableColumn *)aTableColumn
 		} else if ( [anObject isKindOfClass:[NSData class]] ) {
 			newObject = [mySQLConnection escapeAndQuoteData:anObject];
 		} else {
-			if ( [[anObject description] isEqualToString:@"CURRENT_TIMESTAMP"] ) {
-				newObject = @"CURRENT_TIMESTAMP";
+			NSString *desc = [anObject description];
+			if ( [desc isMatchedByRegex:SPCurrentTimestampPattern] ) {
+				newObject = desc;
 			} else if ([anObject isEqualToString:[prefs stringForKey:SPNullValue]]
 						|| (([columnTypeGroup isEqualToString:@"float"] || [columnTypeGroup isEqualToString:@"integer"] || [columnTypeGroup isEqualToString:@"date"])
-							&& [[anObject description] isEqualToString:@""]))
+							&& [desc isEqualToString:@""]))
 			{
 				newObject = @"NULL";
 			} else if ([columnTypeGroup isEqualToString:@"geometry"]) {
 				newObject = [(NSString*)anObject getGeomFromTextString];
 			} else if ([columnTypeGroup isEqualToString:@"bit"]) {
-				newObject = [NSString stringWithFormat:@"b'%@'", ((![[anObject description] length] || [[anObject description] isEqualToString:@"0"]) ? @"0" : [anObject description])];
+				newObject = [NSString stringWithFormat:@"b'%@'", ((![desc length] || [desc isEqualToString:@"0"]) ? @"0" : desc)];
 			} else if ([columnTypeGroup isEqualToString:@"date"]
-						&& [[anObject description] isEqualToString:@"NOW()"]) {
+						&& [desc isEqualToString:@"NOW()"]) {
 				newObject = @"NOW()";
 			} else {
-				newObject = [mySQLConnection escapeAndQuoteString:[anObject description]];
+				newObject = [mySQLConnection escapeAndQuoteString:desc];
 			}
 		}
 
diff --git a/Source/SPObjectAdditions.h b/Source/SPObjectAdditions.h
@@ -35,4 +35,9 @@
  */
 - (BOOL)isNSNull;
 
+/**
+ * easier to read version of [array containsObject:x]
+ */
+- (BOOL)isInArray:(NSArray *)list;
+
 @end
diff --git a/Source/SPObjectAdditions.m b/Source/SPObjectAdditions.m
@@ -46,6 +46,11 @@ - (BOOL)isNSNull
 	return (self == null);
 }
 
+- (BOOL)isInArray:(NSArray *)list
+{
+	return [list containsObject:self];
+}
+
 - (void)_scrollViewDidChangeBounds:(id)obj
 {
 	NSMutableString *msg = [NSMutableString string];
diff --git a/Source/SPSQLExporter.m b/Source/SPSQLExporter.m
@@ -884,8 +884,8 @@ - (NSString *)_createViewPlaceholderSyntaxForView:(NSString *)viewName
 					[fieldString appendString:@" DEFAULT NULL"];
 				}
 			} 
-			else if (([[column objectForKey:@"type"] isEqualToString:@"TIMESTAMP"] || [[column objectForKey:@"type"] isEqualToString:@"DATETIME"]) && [column objectForKey:@"default"] != [NSNull null] && [[[column objectForKey:@"default"] uppercaseString] isEqualToString:@"CURRENT_TIMESTAMP"]) {
-				[fieldString appendString:@" DEFAULT CURRENT_TIMESTAMP"];
+			else if (([[column objectForKey:@"type"] isInArray:@[@"TIMESTAMP",@"DATETIME"]]) && [[column objectForKey:@"default"] isMatchedByRegex:SPCurrentTimestampPattern]) {
+				[fieldString appendFormat:@" DEFAULT %@",[column objectForKey:@"default"]];
 			} 
 			else {
 				[fieldString appendFormat:@" DEFAULT %@", [connection escapeAndQuoteString:[column objectForKey:@"default"]]];
diff --git a/Source/SPTableContent.m b/Source/SPTableContent.m
@@ -2801,14 +2801,15 @@ - (BOOL)saveRowToTable
 				fieldValue = [mySQLConnection escapeAndQuoteData:rowObject];
 
 			} else {
-				if ([[rowObject description] isEqualToString:@"CURRENT_TIMESTAMP"]) {
-					fieldValue = @"CURRENT_TIMESTAMP";
+				NSString *desc = [rowObject description];
+				if ([desc isMatchedByRegex:SPCurrentTimestampPattern]) {
+					fieldValue = desc;
 				} else if ([fieldTypeGroup isEqualToString:@"bit"]) {
-					fieldValue = [NSString stringWithFormat:@"b'%@'", ((![[rowObject description] length] || [[rowObject description] isEqualToString:@"0"]) ? @"0" : [rowObject description])];
-				} else if ([fieldTypeGroup isEqualToString:@"date"] && [[rowObject description] isEqualToString:@"NOW()"]) {
+					fieldValue = [NSString stringWithFormat:@"b'%@'", ((![desc length] || [desc isEqualToString:@"0"]) ? @"0" : desc)];
+				} else if ([fieldTypeGroup isEqualToString:@"date"] && [desc isEqualToString:@"NOW()"]) {
 					fieldValue = @"NOW()";
 				} else {
-					fieldValue = [mySQLConnection escapeAndQuoteString:[rowObject description]];
+					fieldValue = [mySQLConnection escapeAndQuoteString:desc];
 				}
 			}
 		}
@@ -3426,19 +3427,19 @@ - (void)saveViewCellValue:(id)anObject forTableColumn:(NSTableColumn *)aTableCol
 		} else if ( [anObject isKindOfClass:[NSData class]] ) {
 			newObject = [mySQLConnection escapeAndQuoteData:anObject];
 		} else {
-			if ( [[anObject description] isEqualToString:@"CURRENT_TIMESTAMP"] ) {
-				newObject = @"CURRENT_TIMESTAMP";
+			NSString *desc = [anObject description];
+			if ( [desc isMatchedByRegex:SPCurrentTimestampPattern] ) {
+				newObject = desc;
 			} else if([anObject isEqualToString:[prefs stringForKey:SPNullValue]]) {
 				newObject = @"NULL";
 			} else if ([[columnDefinition objectForKey:@"typegrouping"] isEqualToString:@"geometry"]) {
 				newObject = [(NSString*)anObject getGeomFromTextString];
 			} else if ([[columnDefinition objectForKey:@"typegrouping"] isEqualToString:@"bit"]) {
-				newObject = [NSString stringWithFormat:@"b'%@'", ((![[anObject description] length] || [[anObject description] isEqualToString:@"0"]) ? @"0" : [anObject description])];
-			} else if ([[columnDefinition objectForKey:@"typegrouping"] isEqualToString:@"date"]
-						&& [[anObject description] isEqualToString:@"NOW()"]) {
+				newObject = [NSString stringWithFormat:@"b'%@'", ((![desc length] || [desc isEqualToString:@"0"]) ? @"0" : desc)];
+			} else if ([[columnDefinition objectForKey:@"typegrouping"] isEqualToString:@"date"] && [desc isEqualToString:@"NOW()"]) {
 				newObject = @"NOW()";
 			} else {
-				newObject = [mySQLConnection escapeAndQuoteString:[anObject description]];
+				newObject = [mySQLConnection escapeAndQuoteString:desc];
 			}
 		}
 
diff --git a/Source/SPTableData.m b/Source/SPTableData.m
@@ -1359,7 +1359,8 @@ - (NSDictionary *) parseFieldDefinitionStringParts:(NSArray *)definitionParts
 		// Special timestamp/datetime case - Whether fields are set to update the current timestamp
 		} else if ([detailString isEqualToString:@"ON"] && (definitionPartsIndex + 2 < partsArrayLength)
 					&& [[NSArrayObjectAtIndex(definitionParts, definitionPartsIndex+1) uppercaseString] isEqualToString:@"UPDATE"]
-					&& [[NSArrayObjectAtIndex(definitionParts, definitionPartsIndex+2) uppercaseString] isEqualToString:@"CURRENT_TIMESTAMP"]) {
+					&& [NSArrayObjectAtIndex(definitionParts, definitionPartsIndex+2) isMatchedByRegex:SPCurrentTimestampPattern]) {
+			// mysql requires the CURRENT_TIMESTAMP(n) to be exactly the same as the column types length, so we don't need to keep it, we can just restore it later
 			[fieldDetails setValue:@YES forKey:@"onupdatetimestamp"];
 			definitionPartsIndex += 2;
 
diff --git a/Source/SPTableStructure.m b/Source/SPTableStructure.m
@@ -974,12 +974,12 @@ - (NSString *)_buildPartialColumnDefinitionString:(NSDictionary *)theRow
 				}
 			}
 			// Otherwise, if CURRENT_TIMESTAMP was specified for timestamps/datetimes, use that
-			else if (([theRowType isEqualToString:@"TIMESTAMP"] || [theRowType isEqualToString:@"DATETIME"]) &&
-					[(matches = [[[theRow objectForKey:@"default"] uppercaseString] captureComponentsMatchedByRegex:@"^\\s*CURRENT_TIMESTAMP(?:\\s*\\(\\s*(\\d+)\\s*\\))?\\s*$"]) count])
+			else if ([theRowType isInArray:@[@"TIMESTAMP",@"DATETIME"]] &&
+					[(matches = [[[theRow objectForKey:@"default"] uppercaseString] captureComponentsMatchedByRegex:SPCurrentTimestampPattern]) count])
 			{
 				[queryString appendString:@"\n DEFAULT CURRENT_TIMESTAMP"];
 				NSString *userLen = [matches objectAtIndex:1];
-				//mysql 5.6.4+ allows DATETIME(n) for fractional seconds, which in turn requires CURRENT_TIMESTAMP(n).
+				// mysql 5.6.4+ allows DATETIME(n) for fractional seconds, which in turn requires CURRENT_TIMESTAMP(n) with the same n!
 				// Also, if the user explicitly added one we should never ignore that.
 				if([userLen length] || fieldDefIncludesLen) {
 					[queryString appendFormat:@"(%@)",([userLen length]? userLen : [theRow objectForKey:@"length"])];
@@ -1003,6 +1003,10 @@ - (NSString *)_buildPartialColumnDefinitionString:(NSDictionary *)theRow
 
 		if ([theRowExtra length] && ![theRowExtra isEqualToString:@"NONE"]) {
 			[queryString appendFormat:@"\n %@", theRowExtra];
+			//fix our own default item if needed
+			if([theRowExtra isEqualToString:@"ON UPDATE CURRENT_TIMESTAMP"] && fieldDefIncludesLen) {
+				[queryString appendFormat:@"(%@)",[theRow objectForKey:@"length"]];
+			}
 		}
 	}
 
diff --git a/Source/SPTableStructureLoading.m b/Source/SPTableStructureLoading.m
@@ -227,9 +227,15 @@ - (void)loadTable:(NSString *)aTable
 		}
 		
 		// For timestamps/datetime check to see whether "on update CURRENT_TIMESTAMP"  and set Extra accordingly
-		else if (([type isEqualToString:@"TIMESTAMP"] || [type isEqualToString:@"DATETIME"]) &&
-				 [[theField objectForKey:@"onupdatetimestamp"] integerValue]) {
-			[theField setObject:@"on update CURRENT_TIMESTAMP" forKey:@"Extra"];
+		else if ([type isInArray:@[@"TIMESTAMP",@"DATETIME"]] && [[theField objectForKey:@"onupdatetimestamp"] boolValue]) {
+			NSString *ouct = @"on update CURRENT_TIMESTAMP";
+			// restore a length parameter if the field has fractional seconds.
+			// the parameter of current_timestamp MUST match the field's length in that case, so we can just 'guess' it.
+			NSString *fieldLen = [theField objectForKey:@"length"];
+			if([fieldLen length] && ![fieldLen isEqualToString:@"0"]) {
+				ouct = [ouct stringByAppendingFormat:@"(%@)",fieldLen];
+			}
+			[theField setObject:ouct forKey:@"Extra"];
 		}
 	}
 	

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,11 @@ - (BOOL)isNSNull`
`46`	`46`	`return (self == null);`
`47`	`47`	`}`
`48`	`48`
	`49`	`+- (BOOL)isInArray:(NSArray *)list`
	`50`	`+{`
	`51`	`+ return [list containsObject:self];`
	`52`	`+}`
	`53`	`+`
`49`	`54`	`- (void)_scrollViewDidChangeBounds:(id)obj`
`50`	`55`	`{`
`51`	`56`	`NSMutableString *msg = [NSMutableString string];`
Original file line number	Diff line number	Diff line change
`@@ -884,8 +884,8 @@ - (NSString )_createViewPlaceholderSyntaxForView:(NSString )viewName`
`884`	`884`	`[fieldString appendString:@" DEFAULT NULL"];`
`885`	`885`	`}`
`886`	`886`	`}`
`887`		`- else if (([[column objectForKey:@"type"] isEqualToString:@"TIMESTAMP"] \|\| [[column objectForKey:@"type"] isEqualToString:@"DATETIME"]) && [column objectForKey:@"default"] != [NSNull null] && [[[column objectForKey:@"default"] uppercaseString] isEqualToString:@"CURRENT_TIMESTAMP"]) {`
`888`		`- [fieldString appendString:@" DEFAULT CURRENT_TIMESTAMP"];`
	`887`	`+ else if (([[column objectForKey:@"type"] isInArray:@[@"TIMESTAMP",@"DATETIME"]]) && [[column objectForKey:@"default"] isMatchedByRegex:SPCurrentTimestampPattern]) {`
	`888`	`+ [fieldString appendFormat:@" DEFAULT %@",[column objectForKey:@"default"]];`
`889`	`889`	`}`
`890`	`890`	`else {`
`891`	`891`	`[fieldString appendFormat:@" DEFAULT %@", [connection escapeAndQuoteString:[column objectForKey:@"default"]]];`
Original file line number	Diff line number	Diff line change
`@@ -974,12 +974,12 @@ - (NSString )_buildPartialColumnDefinitionString:(NSDictionary )theRow`
`974`	`974`	`}`
`975`	`975`	`}`
`976`	`976`	`// Otherwise, if CURRENT_TIMESTAMP was specified for timestamps/datetimes, use that`
`977`		`- else if (([theRowType isEqualToString:@"TIMESTAMP"] \|\| [theRowType isEqualToString:@"DATETIME"]) &&`
`978`		`- [(matches = [[[theRow objectForKey:@"default"] uppercaseString] captureComponentsMatchedByRegex:@"^\\sCURRENT_TIMESTAMP(?:\\s\\(\\s(\\d+)\\s\\))?\\s*$"]) count])`
	`977`	`+ else if ([theRowType isInArray:@[@"TIMESTAMP",@"DATETIME"]] &&`
	`978`	`+ [(matches = [[[theRow objectForKey:@"default"] uppercaseString] captureComponentsMatchedByRegex:SPCurrentTimestampPattern]) count])`
`979`	`979`	`{`
`980`	`980`	`[queryString appendString:@"\n DEFAULT CURRENT_TIMESTAMP"];`
`981`	`981`	`NSString *userLen = [matches objectAtIndex:1];`
`982`		`- //mysql 5.6.4+ allows DATETIME(n) for fractional seconds, which in turn requires CURRENT_TIMESTAMP(n).`
	`982`	`+ // mysql 5.6.4+ allows DATETIME(n) for fractional seconds, which in turn requires CURRENT_TIMESTAMP(n) with the same n!`
`983`	`983`	`// Also, if the user explicitly added one we should never ignore that.`
`984`	`984`	`if([userLen length] \|\| fieldDefIncludesLen) {`
`985`	`985`	`[queryString appendFormat:@"(%@)",([userLen length]? userLen : [theRow objectForKey:@"length"])];`
`@@ -1003,6 +1003,10 @@ - (NSString )_buildPartialColumnDefinitionString:(NSDictionary )theRow`
`1003`	`1003`
`1004`	`1004`	`if ([theRowExtra length] && ![theRowExtra isEqualToString:@"NONE"]) {`
`1005`	`1005`	`[queryString appendFormat:@"\n %@", theRowExtra];`
	`1006`	`+ //fix our own default item if needed`
	`1007`	`+ if([theRowExtra isEqualToString:@"ON UPDATE CURRENT_TIMESTAMP"] && fieldDefIncludesLen) {`
	`1008`	`+ [queryString appendFormat:@"(%@)",[theRow objectForKey:@"length"]];`
	`1009`	`+ }`
`1006`	`1010`	`}`
`1007`	`1011`	`}`
`1008`	`1012`
Original file line number	Diff line number	Diff line change
`@@ -227,9 +227,15 @@ - (void)loadTable:(NSString *)aTable`
`227`	`227`	`}`
`228`	`228`
`229`	`229`	`// For timestamps/datetime check to see whether "on update CURRENT_TIMESTAMP" and set Extra accordingly`
`230`		`- else if (([type isEqualToString:@"TIMESTAMP"] \|\| [type isEqualToString:@"DATETIME"]) &&`
`231`		`- [[theField objectForKey:@"onupdatetimestamp"] integerValue]) {`
`232`		`- [theField setObject:@"on update CURRENT_TIMESTAMP" forKey:@"Extra"];`
	`230`	`+ else if ([type isInArray:@[@"TIMESTAMP",@"DATETIME"]] && [[theField objectForKey:@"onupdatetimestamp"] boolValue]) {`
	`231`	`+ NSString *ouct = @"on update CURRENT_TIMESTAMP";`
	`232`	`+ // restore a length parameter if the field has fractional seconds.`
	`233`	`+ // the parameter of current_timestamp MUST match the field's length in that case, so we can just 'guess' it.`
	`234`	`+ NSString *fieldLen = [theField objectForKey:@"length"];`
	`235`	`+ if([fieldLen length] && ![fieldLen isEqualToString:@"0"]) {`
	`236`	`+ ouct = [ouct stringByAppendingFormat:@"(%@)",fieldLen];`
	`237`	`+ }`
	`238`	`+ [theField setObject:ouct forKey:@"Extra"];`
`233`	`239`	`}`
`234`	`240`	`}`
`235`	`241`