Skip to content
Permalink
Browse files
Attempt at fixing a random exception/crash involving SPIndexesController
  • Loading branch information
dmoagx committed Feb 24, 2019
1 parent c88e7c5 commit 664a46cd7cfaf8ea1cb7f5172b5f98f69a97bc25
Showing with 8 additions and 3 deletions.
  1. +8 −3 Source/SPIndexesController.m
@@ -524,6 +524,8 @@ - (void)setFields:(NSArray *)tableFields
[indexedFields removeAllObjects];

if ([fields count]) [indexedFields addObject:[[[fields objectAtIndex:0] mutableCopy] autorelease]];

[indexedColumnsTableView reloadData];
}

/**
@@ -883,9 +885,12 @@ - (void)_addIndexUsingDetails:(NSDictionary *)indexDetails
[tempIndexedColumns release];
}

// Reset indexed fields to default
[indexedFields removeAllObjects];
[indexedFields addObject:[[[fields objectAtIndex:0] mutableCopy] autorelease]];
SPMainQSync(^{
// Reset indexed fields to default
[indexedFields removeAllObjects];
[indexedFields addObject:[[[fields objectAtIndex:0] mutableCopy] autorelease]];
[indexedColumnsTableView reloadData];
});

[dbDocument endTask];
}

6 comments on commit 664a46c

@lievikoff

This comment has been minimized.

Copy link

@lievikoff lievikoff replied Mar 20, 2019

That is amazing. Thank you! It finally doesn't crash.
macOS: 10.14.3

@ccc469

This comment has been minimized.

Copy link

@ccc469 ccc469 replied Mar 26, 2019

你好,正式版是什么时候更新?

@rohithrpai

This comment has been minimized.

Copy link

@rohithrpai rohithrpai replied Apr 24, 2019

Hey @dmoagx ! How to do you make the filter content default to all the tabs that you open on the test build
image

@floodedcodeboy

This comment has been minimized.

Copy link

@floodedcodeboy floodedcodeboy replied Apr 30, 2019

when will this hit the stable channel? The App dies every time I close a tab :(

@rhayun

This comment has been minimized.

Copy link

@rhayun rhayun replied May 1, 2019

Thanks looking forward it to be in stable channel

@lgouger

This comment has been minimized.

Copy link

@lgouger lgouger replied May 7, 2019

How do I clear the last filter when using the filter bar? I like being able to add multiple filter conditions, but how do I get back to an unfiltered view?

Please sign in to comment.