Skip to content

Commit

Permalink
Attempt at fixing a random exception/crash involving SPIndexesController
Browse files Browse the repository at this point in the history
  • Loading branch information
dmoagx committed Feb 24, 2019
1 parent c88e7c5 commit 664a46c
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions Source/SPIndexesController.m
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,8 @@ - (void)setFields:(NSArray *)tableFields
[indexedFields removeAllObjects];

if ([fields count]) [indexedFields addObject:[[[fields objectAtIndex:0] mutableCopy] autorelease]];

[indexedColumnsTableView reloadData];
}

/**
Expand Down Expand Up @@ -883,9 +885,12 @@ - (void)_addIndexUsingDetails:(NSDictionary *)indexDetails
[tempIndexedColumns release];
}

// Reset indexed fields to default
[indexedFields removeAllObjects];
[indexedFields addObject:[[[fields objectAtIndex:0] mutableCopy] autorelease]];
SPMainQSync(^{
// Reset indexed fields to default
[indexedFields removeAllObjects];
[indexedFields addObject:[[[fields objectAtIndex:0] mutableCopy] autorelease]];
[indexedColumnsTableView reloadData];
});

[dbDocument endTask];
}
Expand Down

6 comments on commit 664a46c

@lievikoff
Copy link

@lievikoff lievikoff commented on 664a46c Mar 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is amazing. Thank you! It finally doesn't crash.
macOS: 10.14.3

@ccc469
Copy link

@ccc469 ccc469 commented on 664a46c Mar 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你好,正式版是什么时候更新?

@rohithrpai
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dmoagx ! How to do you make the filter content default to all the tabs that you open on the test build
image

@floodedcodeboy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when will this hit the stable channel? The App dies every time I close a tab :(

@rhayun
Copy link

@rhayun rhayun commented on 664a46c May 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looking forward it to be in stable channel

@lgouger
Copy link

@lgouger lgouger commented on 664a46c May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I clear the last filter when using the filter bar? I like being able to add multiple filter conditions, but how do I get back to an unfiltered view?

Please sign in to comment.