#2711 no-longer truncate binary columns whlie editing

abhibeckert · abhibeckert · commit a775a2392362 · 2017-03-03T14:15:11.000+10:00
diff --git a/Source/SPTableContentDataSource.m b/Source/SPTableContentDataSource.m
@@ -130,8 +130,12 @@ - (id)tableView:(SPCopyTable *)tableView objectValueForTableColumn:(NSTableColum
 				fieldEditorCheckLock = &tableValuesLock;
 			}
 
-			// Always retrieve the short string representation, truncating the value where necessary
-			return [value shortStringRepresentationUsingEncoding:[mySQLConnection stringEncoding]];
+			// Unless we're editing, always retrieve the short string representation, truncating the value where necessary
+			if ([tableView editedColumn] == (NSInteger)columnIndex || [tableView editedRow] == rowIndex) {
+				return [value stringRepresentationUsingEncoding:[mySQLConnection stringEncoding]];
+			} else {
+				return [value shortStringRepresentationUsingEncoding:[mySQLConnection stringEncoding]];
+			}
 		}
 		
 		if ([value isSPNotLoaded]) {

Original file line number	Diff line number	Diff line change
`@@ -130,8 +130,12 @@ - (id)tableView:(SPCopyTable *)tableView objectValueForTableColumn:(NSTableColum`
`130`	`130`	`fieldEditorCheckLock = &tableValuesLock;`
`131`	`131`	`}`
`132`	`132`
`133`		`- // Always retrieve the short string representation, truncating the value where necessary`
`134`		`- return [value shortStringRepresentationUsingEncoding:[mySQLConnection stringEncoding]];`
	`133`	`+ // Unless we're editing, always retrieve the short string representation, truncating the value where necessary`
	`134`	`+ if ([tableView editedColumn] == (NSInteger)columnIndex \|\| [tableView editedRow] == rowIndex) {`
	`135`	`+ return [value stringRepresentationUsingEncoding:[mySQLConnection stringEncoding]];`
	`136`	`+ } else {`
	`137`	`+ return [value shortStringRepresentationUsingEncoding:[mySQLConnection stringEncoding]];`
	`138`	`+ }`
`135`	`139`	`}`
`136`	`140`
`137`	`141`	`if ([value isSPNotLoaded]) {`