Permalink
Browse files

Fix one case of "SSH input fields cut off"

When the last selected favorite was "Quick Connect" with SSH, on the next launch SSH would be re-selected, but the fields other than SSH Host would be cut off.

This was caused by a race condition between our window setup code and Cocoas window restoration code. Solved by disabling window restoration for now (didn't really work for us  anyway).
  • Loading branch information...
dmoagx committed Feb 8, 2015
1 parent 19a1c9f commit b1e32f6583f113c279dcde61f4f531d637118bdd
Showing with 6 additions and 0 deletions.
  1. +6 −0 Source/SPWindowController.m
@@ -90,6 +90,12 @@ - (void)awakeFromNib
[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(tabDragStarted:) name:PSMTabDragDidBeginNotification object:nil];
[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(tabDragStopped:) name:PSMTabDragDidEndNotification object:nil];
[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_updateLineHidingViewState) name:SPWindowToolbarDidToggleNotification object:nil];
// Because we are a document-based app we automatically adopt window restoration on 10.7+.
// However that causes a race condition with our own window setup code.
// Remove this when we actually support restoration.
if([[self window] respondsToSelector:@selector(setRestorable:)])
[[self window] setRestorable:NO];
}
#pragma mark -

0 comments on commit b1e32f6

Please sign in to comment.